Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: sdk/lib/io/string_transformer.dart

Issue 1847843002: Steps towards making the convert library strong-mode compliant. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Relax type and fix missed converters. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/data_transformer.dart ('k') | tests/lib/convert/chunked_conversion1_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/string_transformer.dart
diff --git a/sdk/lib/io/string_transformer.dart b/sdk/lib/io/string_transformer.dart
index 16e721b4baf05c66616629da2fea70a4e17774f2..b6f4524238321ce322320a7756289d4c6d1cb287 100644
--- a/sdk/lib/io/string_transformer.dart
+++ b/sdk/lib/io/string_transformer.dart
@@ -25,7 +25,7 @@ class SystemEncoding extends Encoding {
List<int> encode(String input) => encoder.convert(input);
String decode(List<int> encoded) => decoder.convert(encoded);
- Converter<String, List<int>> get encoder {
+ ChunkedConverter<String, List<int>, String, List<int>> get encoder {
if (Platform.operatingSystem == "windows") {
return const _WindowsCodePageEncoder();
} else {
@@ -33,7 +33,7 @@ class SystemEncoding extends Encoding {
}
}
- Converter<List<int>, String> get decoder {
+ ChunkedConverter<List<int>, String, List<int>, String> get decoder {
if (Platform.operatingSystem == "windows") {
return const _WindowsCodePageDecoder();
} else {
@@ -42,7 +42,8 @@ class SystemEncoding extends Encoding {
}
}
-class _WindowsCodePageEncoder extends Converter<String, List<int>> {
+class _WindowsCodePageEncoder
+ extends ChunkedConverter<String, List<int>, String, List<int>> {
const _WindowsCodePageEncoder();
@@ -97,7 +98,8 @@ class _WindowsCodePageEncoderSink extends StringConversionSinkBase {
}
-class _WindowsCodePageDecoder extends Converter<List<int>, String> {
+class _WindowsCodePageDecoder
+ extends ChunkedConverter<List<int>, String, List<int>, String> {
const _WindowsCodePageDecoder();
« no previous file with comments | « sdk/lib/io/data_transformer.dart ('k') | tests/lib/convert/chunked_conversion1_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698