Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: sdk/lib/convert/base64.dart

Issue 1847843002: Steps towards making the convert library strong-mode compliant. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Relax type and fix missed converters. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/convert/ascii.dart ('k') | sdk/lib/convert/chunked_conversion.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/convert/base64.dart
diff --git a/sdk/lib/convert/base64.dart b/sdk/lib/convert/base64.dart
index c6cac6ed76cf42f1d7641cebbef604f7de72eb13..ff3a43959e1074818c120cbaa56c13f604357ca7 100644
--- a/sdk/lib/convert/base64.dart
+++ b/sdk/lib/convert/base64.dart
@@ -70,7 +70,8 @@ class Base64Codec extends Codec<List<int>, String> {
*
* The results are ASCII strings using a restricted alphabet.
*/
-class Base64Encoder extends Converter<List<int>, String> {
+class Base64Encoder extends
+ ChunkedConverter<List<int>, String, List<int>, String> {
final bool _urlSafe;
const Base64Encoder() : _urlSafe = false;
@@ -89,14 +90,6 @@ class Base64Encoder extends Converter<List<int>, String> {
}
return new _AsciiBase64EncoderSink(sink, _urlSafe);
}
-
- Stream<String> bind(Stream<List<int>> stream) {
- return new Stream<String>.eventTransformed(
- stream,
- (EventSink sink) =>
- new _ConverterStreamEventSink<List<int>, String>(
- this, sink));
- }
}
/**
@@ -348,7 +341,9 @@ class _Utf8Base64EncoderSink extends _Base64EncoderSink {
*
* The encoding is required to be properly padded.
*/
-class Base64Decoder extends Converter<String, List<int>> {
+class Base64Decoder extends
+ ChunkedConverter<String, List<int>, String, List<int>> {
+
const Base64Decoder();
List<int> convert(String input, [int start = 0, int end]) {
« no previous file with comments | « sdk/lib/convert/ascii.dart ('k') | sdk/lib/convert/chunked_conversion.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698