Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1847823006: media: Fix gn deps on media/mojo/ targets. (Closed)

Created:
4 years, 8 months ago by xhwang
Modified:
4 years, 8 months ago
Reviewers:
jrummell
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Fix gn deps on media/mojo/ targets. gn check out/GN media/mojo/services:* is green now. BUG=599578 Committed: https://crrev.com/1de29c2258ed6b536ebb61e4c365ef22b84d5042 Cr-Commit-Position: refs/heads/master@{#385111}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M media/mojo/services/BUILD.gn View 6 chunks +10 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_media_application_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
xhwang
PTAL
4 years, 8 months ago (2016-04-02 06:01:43 UTC) #2
jrummell
lgtm
4 years, 8 months ago (2016-04-05 01:03:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847823006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847823006/1
4 years, 8 months ago (2016-04-05 04:54:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 05:54:28 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 05:56:06 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1de29c2258ed6b536ebb61e4c365ef22b84d5042
Cr-Commit-Position: refs/heads/master@{#385111}

Powered by Google App Engine
This is Rietveld 408576698