Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1845)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 1847823005: Fix Event Latency Info on generate gesture events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove debugging Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index d50b5584e8889b69d0e88cd982e81536a8151005..b7bee6d27115b8399ea10b0dfd78a6b3982de1cc 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -201,7 +201,8 @@ RenderWidgetHostImpl::RenderWidgetHostImpl(RenderWidgetHostDelegate* delegate,
pending_mouse_lock_request_(false),
allow_privileged_mouse_lock_(false),
has_touch_handler_(false),
- is_in_gesture_scroll_(false),
+ is_in_touchpad_gesture_scroll_(false),
+ is_in_touchscreen_gesture_scroll_(false),
received_paint_after_load_(false),
next_browser_snapshot_id_(1),
owned_by_render_frame_host_(false),
@@ -1027,21 +1028,26 @@ void RenderWidgetHostImpl::ForwardGestureEventWithLatencyInfo(
// TODO(wjmaclean) Remove the code for supporting resending gesture events
// when WebView transitions to OOPIF and BrowserPlugin is removed.
// http://crbug.com/533069
+ bool* is_in_gesture_scroll =
+ gesture_event.sourceDevice ==
+ blink::WebGestureDevice::WebGestureDeviceTouchpad
+ ? &is_in_touchpad_gesture_scroll_
+ : &is_in_touchscreen_gesture_scroll_;
tdresser 2016/04/04 15:47:48 I think it would be simpler to just have a bool "i
tdresser 2016/04/04 15:57:21 Dave pointed out this is simpler, cause we don't n
if (gesture_event.type == blink::WebInputEvent::GestureScrollBegin) {
- DCHECK(!is_in_gesture_scroll_);
- is_in_gesture_scroll_ = true;
+ DCHECK(!(*is_in_gesture_scroll));
+ *is_in_gesture_scroll = true;
} else if (gesture_event.type == blink::WebInputEvent::GestureScrollEnd ||
gesture_event.type == blink::WebInputEvent::GestureFlingStart) {
- DCHECK(is_in_gesture_scroll_ ||
+ DCHECK(*is_in_gesture_scroll ||
(gesture_event.type == blink::WebInputEvent::GestureFlingStart &&
gesture_event.sourceDevice ==
blink::WebGestureDevice::WebGestureDeviceTouchpad));
- is_in_gesture_scroll_ = false;
+ *is_in_gesture_scroll = false;
}
bool scroll_update_needs_wrapping =
gesture_event.type == blink::WebInputEvent::GestureScrollUpdate &&
- gesture_event.resendingPluginId != -1 && !is_in_gesture_scroll_;
+ gesture_event.resendingPluginId != -1 && !(*is_in_gesture_scroll);
if (scroll_update_needs_wrapping) {
ForwardGestureEventWithLatencyInfo(

Powered by Google App Engine
This is Rietveld 408576698