Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: build/android/lint/suppressions.xml

Issue 1847823003: 🍫 Enable support-annotations lint checks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lint-swiper
Patch Set: add android.jar, revert .gypi change Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/gyp/lint.py ('k') | build/config/android/internal_rules.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 <issue id="IconLocation"> 64 <issue id="IconLocation">
65 <!-- It is OK for content_shell_apk to have missing assets. --> 65 <!-- It is OK for content_shell_apk to have missing assets. -->
66 <ignore path="content/shell/android/java/res/"/> 66 <ignore path="content/shell/android/java/res/"/>
67 <!-- Suppression for chrome/test/chromedriver/test/webview_shell/java/res/dr awable/icon.png --> 67 <!-- Suppression for chrome/test/chromedriver/test/webview_shell/java/res/dr awable/icon.png -->
68 <ignore path="res/drawable/icon.png"/> 68 <ignore path="res/drawable/icon.png"/>
69 <!-- TODO(lambroslambrou) remove this once crbug.com/502030 is fixed. --> 69 <!-- TODO(lambroslambrou) remove this once crbug.com/502030 is fixed. -->
70 <ignore path="remoting/android/java/res"/> 70 <ignore path="remoting/android/java/res"/>
71 </issue> 71 </issue>
72 <issue id="InconsistentLayout" severity="ignore"/> 72 <issue id="InconsistentLayout" severity="ignore"/>
73 <issue id="InflateParams" severity="ignore"/> 73 <issue id="InflateParams" severity="ignore"/>
74 <issue id="LongLogTag" severity="ignore"/>
74 <issue id="MissingApplicationIcon" severity="ignore"/> 75 <issue id="MissingApplicationIcon" severity="ignore"/>
76 <issue id="MissingPermission" severity="ignore"/>
75 <issue id="MissingRegistered" severity="ignore"/> 77 <issue id="MissingRegistered" severity="ignore"/>
76 <issue id="MissingVersion"> 78 <issue id="MissingVersion">
77 <ignore path="AndroidManifest.xml"/> 79 <ignore path="AndroidManifest.xml"/>
78 </issue> 80 </issue>
79 <issue id="InlinedApi" severity="ignore"/> 81 <issue id="InlinedApi" severity="ignore"/>
80 <issue id="NewApi"> 82 <issue id="NewApi">
81 <ignore regexp="Attribute `paddingStart` referenced here can result in a cra sh on some specific devices older than API 17"/> 83 <ignore regexp="Attribute `paddingStart` referenced here can result in a cra sh on some specific devices older than API 17"/>
82 <ignore path="org/chromium/base/AnimationFrameTimeHistogram$Recorder.class"/ > 84 <ignore path="org/chromium/base/AnimationFrameTimeHistogram$Recorder.class"/ >
83 <ignore path="org/chromium/base/JavaHandlerThread.class"/> 85 <ignore path="org/chromium/base/JavaHandlerThread.class"/>
84 <ignore path="org/chromium/base/SysUtils.class"/> 86 <ignore path="org/chromium/base/SysUtils.class"/>
(...skipping 24 matching lines...) Expand all
109 <ignore path="content/shell/android/shell_apk/res/values/strings.xml" /> 111 <ignore path="content/shell/android/shell_apk/res/values/strings.xml" />
110 </issue> 112 </issue>
111 <issue id="SignatureOrSystemPermissions" severity="ignore"/> 113 <issue id="SignatureOrSystemPermissions" severity="ignore"/>
112 <issue id="UnusedAttribute" severity="ignore"/> 114 <issue id="UnusedAttribute" severity="ignore"/>
113 <issue id="ViewConstructor" severity="ignore"/> 115 <issue id="ViewConstructor" severity="ignore"/>
114 <issue id="WrongCall" severity="ignore"/> 116 <issue id="WrongCall" severity="ignore"/>
115 <issue id="UselessParent"> 117 <issue id="UselessParent">
116 <ignore path="chrome/android/java/res/layout/data_reduction_promo_screen.xml " /> 118 <ignore path="chrome/android/java/res/layout/data_reduction_promo_screen.xml " />
117 </issue> 119 </issue>
118 </lint> 120 </lint>
OLDNEW
« no previous file with comments | « build/android/gyp/lint.py ('k') | build/config/android/internal_rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698