Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1847803003: Revert of [libfuzzer] supporting libfuzzer on mac with asan (Closed)

Created:
4 years, 8 months ago by kjellander_chromium
Modified:
4 years, 8 months ago
CC:
chromium-reviews, kjellander_chromium, pbos
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [libfuzzer] supporting libfuzzer on mac with asan (patchset #6 id:100001 of https://codereview.chromium.org/1818273002/ ) Reason for revert: I've spent a fair amount of time trying to debug this and come up with a workaround for us. Our bot (https://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_rel/builds/8218/) doesn't have ASan enabled do I don't even see why we're hit by the error we're seeing. I'll revert this for now waiting for the correct fix since there were several problems with this CL. FYI: I'm also unable to locate the tsan and ubsan libraries in LLVM: my checkout only has the asan one: $ find third_party/llvm-build/Release+Asserts/ -name libclang* third_party/llvm-build/Release+Asserts//lib/clang/3.9.0/lib/darwin/libclang_rt.asan_osx_dynamic.dylib third_party/llvm-build/Release+Asserts//lib/clang/3.9.0/lib/darwin/libclang_rt.profile_osx.a Original issue's description: > Experimental support for fuzzing on mac. > > BUG=597066 > > Committed: https://crrev.com/e9aba58f6cbfee6fec2af0ec4832a3c23ec66b9f > Cr-Commit-Position: refs/heads/master@{#383389} TBR=dpranke@chromium.org,kcc@chromium.org,glider@chromium.org,rsesek@chromium.org,aizatsky@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=597066 Committed: https://crrev.com/d859208cab47c131d7374c9ac7c01dc4bcab198a Cr-Commit-Position: refs/heads/master@{#384289}

Patch Set 1 #

Patch Set 2 : Fixed merge conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -44 lines) Patch
M BUILD.gn View 1 2 chunks +2 lines, -7 lines 0 comments Download
M build/config/sanitizers/BUILD.gn View 1 3 chunks +1 line, -24 lines 0 comments Download
M build/config/sanitizers/sanitizers.gni View 1 1 chunk +2 lines, -2 lines 0 comments Download
M testing/libfuzzer/BUILD.gn View 1 1 chunk +0 lines, -10 lines 0 comments Download
M testing/libfuzzer/fuzzer_test.gni View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
kjellander_chromium
Created Revert of [libfuzzer] supporting libfuzzer on mac with asan
4 years, 8 months ago (2016-03-31 15:06:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847803003/1
4 years, 8 months ago (2016-03-31 15:06:39 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/11664) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-03-31 15:08:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847803003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847803003/140001
4 years, 8 months ago (2016-03-31 15:17:32 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:140001)
4 years, 8 months ago (2016-03-31 15:51:54 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d859208cab47c131d7374c9ac7c01dc4bcab198a Cr-Commit-Position: refs/heads/master@{#384289}
4 years, 8 months ago (2016-03-31 15:52:53 UTC) #10
Dirk Pranke
4 years, 8 months ago (2016-03-31 16:09:15 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698