Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: pkg/barback/lib/src/asset.dart

Issue 18478004: Make Asset.readAsString() async. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/barback/test/utils.dart » ('j') | pkg/barback/test/utils.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/lib/src/asset.dart
diff --git a/pkg/barback/lib/src/asset.dart b/pkg/barback/lib/src/asset.dart
index 2de733fcf1f1b268714b8f3e229fe9824c571cc9..636d468886d3d65ca6bccf6354328e0e51f702b8 100644
--- a/pkg/barback/lib/src/asset.dart
+++ b/pkg/barback/lib/src/asset.dart
@@ -36,7 +36,7 @@ abstract class Asset {
/// Returns the contents of the asset as a string.
// TODO(rnystrom): Figure out how binary assets should be handled.
- String readAsString();
+ Future<String> readAsString();
/// Streams the contents of the asset.
Stream<List<int>> read();
@@ -51,7 +51,7 @@ class _FileAsset implements Asset {
final File _file;
_FileAsset(this._file);
- String readAsString() => _file.readAsStringSync();
+ Future<String> readAsString() => _file.readAsString();
Stream<List<int>> read() => _file.openRead();
String toString() => 'File "${_file.path}"';
@@ -66,7 +66,7 @@ class _StringAsset implements Asset {
_StringAsset(this._contents);
- String readAsString() => _contents;
+ Future<String> readAsString() => new Future.value(_contents);
// TODO(rnystrom): Implement this and handle encoding.
Stream<List<int>> read() => throw new UnimplementedError();
« no previous file with comments | « no previous file | pkg/barback/test/utils.dart » ('j') | pkg/barback/test/utils.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698