Vibration cannot be canceled during pattern vibration.

Source/modules/vibration/NavigatorVibration.cpp

 /*
  *  Copyright (C) 2012 Samsung Electronics
  *
  *  This library is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU Library General Public
  *  License as published by the Free Software Foundation; either
  *  version 2 of the License, or (at your option) any later version.
  *
  *  This library is distributed in the hope that it will be useful,
  *  but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 66 matching lines @@
 
     if (!m_pattern.size())
         return true;
 
     if (m_pattern.size() == 1 && !m_pattern[0]) {
         m_pattern.clear();
         return true;
     }
 
     m_timerStart.startOneShot(0);
+    m_isVibrating = true;

[abarth-chromium, 2013/07/08 21:04:59]

Is that true?  Don't we need to wait until the one-shot timer has fired before
we'll actually be vibrating?  Perhaps this variable just needs to be renamed...

[kihong, 2013/07/12 11:04:13]

If we move this to the timerStartFired(), there is a problem like below.
1. vibrate is called
2. cancel is called, right before timerStartFired is dispatched.
In this case vibration will not be canceled, because m_isVibrating is false yet.
And device will vibrate, even if cancel is called.
Therefore m_isVibrating need to be positioned here.

In addition, I've supposed that timer will be dispatched right after firing.
It's not much different from real vibrating time.

     return true;
 }
 
 void NavigatorVibration::cancelVibration()
 {
     m_pattern.clear();
     if (m_isVibrating) {
         WebKit::Platform::current()->cancelVibration();
         m_isVibrating = false;
         m_timerStop.stop();
     }
 }
 
 void NavigatorVibration::suspendVibration()
 {
     if (!m_isVibrating)
         return;
 
     m_pattern.insert(0, m_timerStop.nextFireInterval());
     m_timerStop.stop();
     cancelVibration();
 }
 
 void NavigatorVibration::resumeVibration()
 {
     ASSERT(!m_timerStart.isActive());
 
     m_timerStart.startOneShot(0);
+    m_isVibrating = true;
 }
 
 void NavigatorVibration::timerStartFired(Timer<NavigatorVibration>* timer)
 {
     ASSERT_UNUSED(timer, timer == &m_timerStart);
 
     if (m_pattern.size()) {
-        m_isVibrating = true;
         WebKit::Platform::current()->vibrate(m_pattern[0]);
         m_timerStop.startOneShot(m_pattern[0] / 1000.0);
         m_pattern.remove(0);
     }
 }
 
 void NavigatorVibration::timerStopFired(Timer<NavigatorVibration>* timer)
 {
     ASSERT_UNUSED(timer, timer == &m_timerStop);
 
-    m_isVibrating = false;
+    if (m_pattern.isEmpty())
+        m_isVibrating = false;
 
     if (m_pattern.size()) {
         m_timerStart.startOneShot(m_pattern[0] / 1000.0);
         m_pattern.remove(0);
     }
 }
 
 bool NavigatorVibration::vibrate(Navigator* navigator, unsigned time)
 {
     VibrationPattern pattern;
@@ skipping 21 matching lines @@
     }
     return navigatorVibration;
 }
 
 const char* NavigatorVibration::supplementName()
 {
     return "NavigatorVibration";
 }
 
 } // namespace WebCore