Vibration cannot be canceled during pattern vibration.

Source/modules/vibration/NavigatorVibration.cpp

 /*
  *  Copyright (C) 2012 Samsung Electronics
  *
  *  This library is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU Library General Public
  *  License as published by the Free Software Foundation; either
  *  version 2 of the License, or (at your option) any later version.
  *
  *  This library is distributed in the hope that it will be useful,
  *  but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 66 matching lines @@
 
     if (!m_pattern.size())
         return true;
 
     if (m_pattern.size() == 1 && !m_pattern[0]) {
         m_pattern.clear();
         return true;
     }
 
     m_timerStart.startOneShot(0);
+    m_isVibrating = true;
     return true;
 }
 
 void NavigatorVibration::cancelVibration()
 {
     m_pattern.clear();
     if (m_isVibrating) {
         WebKit::Platform::current()->cancelVibration();
         m_isVibrating = false;
         m_timerStop.stop();
     }
 }
 
 void NavigatorVibration::suspendVibration()
 {
     if (!m_isVibrating)
         return;
 
     m_pattern.insert(0, m_timerStop.nextFireInterval());
     m_timerStop.stop();
     cancelVibration();
 }
 
 void NavigatorVibration::resumeVibration()
 {
     ASSERT(!m_timerStart.isActive());
 
     m_timerStart.startOneShot(0);
+    m_isVibrating = true;
 }
 
 void NavigatorVibration::timerStartFired(Timer<NavigatorVibration>* timer)
 {
     ASSERT_UNUSED(timer, timer == &m_timerStart);
 
     if (m_pattern.size()) {
-        m_isVibrating = true;
         WebKit::Platform::current()->vibrate(m_pattern[0]);
         m_timerStop.startOneShot(m_pattern[0] / 1000.0);
         m_pattern.remove(0);
     }
 }
 
 void NavigatorVibration::timerStopFired(Timer<NavigatorVibration>* timer)
 {
     ASSERT_UNUSED(timer, timer == &m_timerStop);
 
-    m_isVibrating = false;

[Michael van Ouwerkerk, 2013/07/03 10:47:55]

I think you want to keep this line, but make it conditional on the pattern being
empty: if (m_pattern.isEmpty())

This way it stays true even during pauses in the pattern, and becomes false when
the pattern ends.

[kihong, 2013/07/08 10:14:06]

Done.

-
     if (m_pattern.size()) {
         m_timerStart.startOneShot(m_pattern[0] / 1000.0);
         m_pattern.remove(0);
+        if (m_pattern.isEmpty())

[Michael van Ouwerkerk, 2013/07/03 10:47:55]

How would this ever happen? It should not, since trailing pauses are removed
from the pattern on line 69: tempPattern.removeLast();

This line represents step 4 in the algorithm described in the specification:
http://dev.w3.org/2009/dap/vibration/#vibration-interface
"If the length of pattern is even and is not zero, then remove the last entry in
pattern."

I think this condition never becomes true, so m_isVibrating never becomes false
unless someone calls navigator.vibrate(0) from JavaScript.

[kihong, 2013/07/08 10:14:06]

Done.

+            m_isVibrating = false;
     }
 }
 
 bool NavigatorVibration::vibrate(Navigator* navigator, unsigned time)
 {
     VibrationPattern pattern;
     pattern.append(time);
     return NavigatorVibration::vibrate(navigator, pattern);
 }
 
@@ skipping 17 matching lines @@
     }
     return navigatorVibration;
 }
 
 const char* NavigatorVibration::supplementName()
 {
     return "NavigatorVibration";
 }
 
 } // namespace WebCore