Issue 18478002: Revert "Correctly report callstack when current function is FunctionCall builtin"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18478002: Revert "Correctly report callstack when current function is FunctionCall builtin" (Closed)

Created:
7 years, 5 months ago by yurys

Modified:
7 years, 5 months ago

Reviewers:
Jakob Kummerow, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Correctly report callstack when current function is FunctionCall builtin" This reverts commit r15426. The new test fails in Debug mode. BUG=None TBR=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15434

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -166 lines)			Patch
M	src/cpu-profiler.h	View	3 chunks	+1 line, -12 lines	0 comments	Download
M	src/cpu-profiler.cc	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	src/cpu-profiler-inl.h	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	src/profile-generator.h	View	4 chunks	+1 line, -9 lines	0 comments	Download
M	src/profile-generator.cc	View	4 chunks	+23 lines, -41 lines	0 comments	Download
M	src/profile-generator-inl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/cctest/test-cpu-profiler.cc	View	1 chunk	+0 lines, -77 lines	0 comments	Download

Total messages: 2 (0 generated)

yurys

Committed patchset #1 manually as r15434 (presubmit successful).

7 years, 5 months ago (2013-07-02 06:26:17 UTC) #1

Message was sent while issue was closed.

lgtm