Revert of Remove RegExp.prototype.source getter compat workaround

Revert of Remove RegExp.prototype.source getter compat workaround (patchset #2 id:20001 of https://codereview.chromium.org/1837843002/ )

Reason for revert:
TC39 decided that this compatibility fix should be standardized.

Original issue's description:
> Remove RegExp.prototype.source getter compat workaround
>
> The getter RegExp.prototype.source is specified in ES2015 to throw when
> called on a non-RegExp instance, such as RegExp.prototype. We had previously
> put in a compatibility workaround for all RegExp getters to make them
> throw on access specifically with RegExp.prototype as the receiver; however,
> we only have evidence that this is needed for properties other than source.
> This patch removes the compatibility workaround for get RegExp.prototype.source
> and gives it semantics precisely as per the ES2015 specification.
>
> R=adamk
> BUG=chromium:581577, v8:4827
> LOG=Y
>
> Committed: https://crrev.com/80803aa89e31839b8f73959776fa7e1923c6b461
> Cr-Commit-Position: refs/heads/master@{#35086}

R=adamk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:581577, v8:4827
LOG=Y

Committed: https://crrev.com/31e806ebd1a33f6c9207f6d3aed7bbdf3bb72cf7
Cr-Commit-Position: refs/heads/master@{#35180}

[Dan Ehrenberg, 2016-03-31 17:23:54]

Created Revert of Remove RegExp.prototype.source getter compat workaround

[Dan Ehrenberg, 2016-03-31 17:24:15]

Description was changed from

==========
Revert of Remove RegExp.prototype.source getter compat workaround (patchset #2
id:20001 of https://codereview.chromium.org/1837843002/ )

Reason for revert:
TC39 decided that this compatibility fix should be standardized.

Original issue's description:
> Remove RegExp.prototype.source getter compat workaround
> 
> The getter RegExp.prototype.source is specified in ES2015 to throw when
> called on a non-RegExp instance, such as RegExp.prototype. We had previously
> put in a compatibility workaround for all RegExp getters to make them
> throw on access specifically with RegExp.prototype as the receiver; however,
> we only have evidence that this is needed for properties other than source.
> This patch removes the compatibility workaround for get
RegExp.prototype.source
> and gives it semantics precisely as per the ES2015 specification.
> 
> R=adamk
> BUG=chromium:581577,v8:4827
> LOG=Y
> 
> Committed: https://crrev.com/80803aa89e31839b8f73959776fa7e1923c6b461
> Cr-Commit-Position: refs/heads/master@{#35086}

TBR=adamk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:581577,v8:4827
==========

to

==========
Revert of Remove RegExp.prototype.source getter compat workaround (patchset #2
id:20001 of https://codereview.chromium.org/1837843002/ )

Reason for revert:
TC39 decided that this compatibility fix should be standardized.

Original issue's description:
> Remove RegExp.prototype.source getter compat workaround
> 
> The getter RegExp.prototype.source is specified in ES2015 to throw when
> called on a non-RegExp instance, such as RegExp.prototype. We had previously
> put in a compatibility workaround for all RegExp getters to make them
> throw on access specifically with RegExp.prototype as the receiver; however,
> we only have evidence that this is needed for properties other than source.
> This patch removes the compatibility workaround for get
RegExp.prototype.source
> and gives it semantics precisely as per the ES2015 specification.
> 
> R=adamk
> BUG=chromium:581577,v8:4827
> LOG=Y
> 
> Committed: https://crrev.com/80803aa89e31839b8f73959776fa7e1923c6b461
> Cr-Commit-Position: refs/heads/master@{#35086}

R=adamk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:581577,v8:4827
==========

[adamk, 2016-03-31 17:24:28]

lgtm

[Dan Ehrenberg, 2016-03-31 17:25:33]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-03-31 17:25:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847783003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847783003/1

[commit-bot: I haz the power, 2016-03-31 17:32:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 17:32:36]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13076)

[Dan Ehrenberg, 2016-03-31 23:09:28]

Description was changed from

==========
Revert of Remove RegExp.prototype.source getter compat workaround (patchset #2
id:20001 of https://codereview.chromium.org/1837843002/ )

Reason for revert:
TC39 decided that this compatibility fix should be standardized.

Original issue's description:
> Remove RegExp.prototype.source getter compat workaround
> 
> The getter RegExp.prototype.source is specified in ES2015 to throw when
> called on a non-RegExp instance, such as RegExp.prototype. We had previously
> put in a compatibility workaround for all RegExp getters to make them
> throw on access specifically with RegExp.prototype as the receiver; however,
> we only have evidence that this is needed for properties other than source.
> This patch removes the compatibility workaround for get
RegExp.prototype.source
> and gives it semantics precisely as per the ES2015 specification.
> 
> R=adamk
> BUG=chromium:581577,v8:4827
> LOG=Y
> 
> Committed: https://crrev.com/80803aa89e31839b8f73959776fa7e1923c6b461
> Cr-Commit-Position: refs/heads/master@{#35086}

R=adamk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:581577,v8:4827
==========

to

==========
Revert of Remove RegExp.prototype.source getter compat workaround (patchset #2
id:20001 of https://codereview.chromium.org/1837843002/ )

Reason for revert:
TC39 decided that this compatibility fix should be standardized.

Original issue's description:
> Remove RegExp.prototype.source getter compat workaround
> 
> The getter RegExp.prototype.source is specified in ES2015 to throw when
> called on a non-RegExp instance, such as RegExp.prototype. We had previously
> put in a compatibility workaround for all RegExp getters to make them
> throw on access specifically with RegExp.prototype as the receiver; however,
> we only have evidence that this is needed for properties other than source.
> This patch removes the compatibility workaround for get
RegExp.prototype.source
> and gives it semantics precisely as per the ES2015 specification.
> 
> R=adamk
> BUG=chromium:581577,v8:4827
> LOG=Y
> 
> Committed: https://crrev.com/80803aa89e31839b8f73959776fa7e1923c6b461
> Cr-Commit-Position: refs/heads/master@{#35086}

R=adamk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:581577,v8:4827
LOG=Y
==========

[Dan Ehrenberg, 2016-03-31 23:09:32]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-03-31 23:09:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847783003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847783003/1

[commit-bot: I haz the power, 2016-04-01 00:37:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-01 00:37:34]

Description was changed from

==========
Revert of Remove RegExp.prototype.source getter compat workaround (patchset #2
id:20001 of https://codereview.chromium.org/1837843002/ )

Reason for revert:
TC39 decided that this compatibility fix should be standardized.

Original issue's description:
> Remove RegExp.prototype.source getter compat workaround
> 
> The getter RegExp.prototype.source is specified in ES2015 to throw when
> called on a non-RegExp instance, such as RegExp.prototype. We had previously
> put in a compatibility workaround for all RegExp getters to make them
> throw on access specifically with RegExp.prototype as the receiver; however,
> we only have evidence that this is needed for properties other than source.
> This patch removes the compatibility workaround for get
RegExp.prototype.source
> and gives it semantics precisely as per the ES2015 specification.
> 
> R=adamk
> BUG=chromium:581577,v8:4827
> LOG=Y
> 
> Committed: https://crrev.com/80803aa89e31839b8f73959776fa7e1923c6b461
> Cr-Commit-Position: refs/heads/master@{#35086}

R=adamk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:581577,v8:4827
LOG=Y
==========

to

==========
Revert of Remove RegExp.prototype.source getter compat workaround (patchset #2
id:20001 of https://codereview.chromium.org/1837843002/ )

Reason for revert:
TC39 decided that this compatibility fix should be standardized.

Original issue's description:
> Remove RegExp.prototype.source getter compat workaround
>
> The getter RegExp.prototype.source is specified in ES2015 to throw when
> called on a non-RegExp instance, such as RegExp.prototype. We had previously
> put in a compatibility workaround for all RegExp getters to make them
> throw on access specifically with RegExp.prototype as the receiver; however,
> we only have evidence that this is needed for properties other than source.
> This patch removes the compatibility workaround for get
RegExp.prototype.source
> and gives it semantics precisely as per the ES2015 specification.
>
> R=adamk
> BUG=chromium:581577,v8:4827
> LOG=Y
>
> Committed: https://crrev.com/80803aa89e31839b8f73959776fa7e1923c6b461
> Cr-Commit-Position: refs/heads/master@{#35086}

R=adamk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:581577,v8:4827
LOG=Y

Committed: https://crrev.com/31e806ebd1a33f6c9207f6d3aed7bbdf3bb72cf7
Cr-Commit-Position: refs/heads/master@{#35180}
==========

[commit-bot: I haz the power, 2016-04-01 00:37:35]

Patchset 1 (id:??) landed as
https://crrev.com/31e806ebd1a33f6c9207f6d3aed7bbdf3bb72cf7
Cr-Commit-Position: refs/heads/master@{#35180}

[Dan Ehrenberg, 2016-04-01 15:18:21]

On 2016/04/01 at 00:37:35, commit-bot wrote:
> Patchset 1 (id:??) landed as
https://crrev.com/31e806ebd1a33f6c9207f6d3aed7bbdf3bb72cf7
> Cr-Commit-Position: refs/heads/master@{#35180}

Looks like this revert happened because the logic for saving built-ins in
extensions (in src/extensions/renderer/safe_builtins.cc) saved
RegExp.prototype.test, but then was disturbed by a mutation to
RegExp.prototype.exec. This could be fixed by basically implementing
$RegExp.test in terms of the initial RegExp.prototype.exec value (toJSON already
goes through far more work), or simply exposing exec and replacing the single
usage.