Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Issue 1847783002: Multiple improvements to windows bash integration. (Closed)

Created:
4 years, 8 months ago by iannucci
Modified:
4 years, 8 months ago
Reviewers:
dnj, agable, Michael Moss
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Multiple improvements to windows bash integration. * `git bash` helper now will either: * launch an interactive bash prompt in the MinGW Terminal Emulator * launch a non-interactive bash shell if arguments are provided * `git bash` now includes python, python/Scripts and svn binaries in the PATH. * depot_tools' colorization now works in MinGW Terminal Emulator * batch scripts are now regenerated if any of them is missing. R=agable@chromium.org, dnj@chromium.org, mmoss@chromium.org BUG=598956 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=299616

Patch Set 1 #

Patch Set 2 : Add direct mode and unbuffered #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -29 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
A bootstrap/win/git-bash.template.sh View 1 1 chunk +12 lines, -0 lines 0 comments Download
M bootstrap/win/win_tools.bat View 2 chunks +15 lines, -11 lines 0 comments Download
M depot-tools-auth.py View 2 chunks +2 lines, -1 line 0 comments Download
M gclient.py View 1 chunk +1 line, -1 line 0 comments Download
D git-bash View 1 chunk +0 lines, -11 lines 0 comments Download
M git_cl.py View 1 chunk +1 line, -1 line 0 comments Download
M git_map_branches.py View 2 chunks +2 lines, -1 line 0 comments Download
M python_runner.sh View 1 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
iannucci
4 years, 8 months ago (2016-03-31 09:49:31 UTC) #1
dnj
This all lgtm. Hard to say if you've hit every tool / impact, so taking ...
4 years, 8 months ago (2016-03-31 15:23:36 UTC) #2
agable
LGTM as well.
4 years, 8 months ago (2016-03-31 16:03:52 UTC) #3
iannucci
On 2016/03/31 at 16:03:52, agable wrote: > LGTM as well. Waiting on this until after ...
4 years, 8 months ago (2016-03-31 18:59:46 UTC) #4
iannucci
4 years, 8 months ago (2016-04-01 01:02:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 299616.

Powered by Google App Engine
This is Rietveld 408576698