Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: third_party/WebKit/LayoutTests/svg/text/bidi-text-query.svg

Issue 1847763002: Only synthesize grapheme widths once for surrogate pair characters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewer comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/svg/text/bidi-text-query.svg
diff --git a/third_party/WebKit/LayoutTests/svg/text/bidi-text-query.svg b/third_party/WebKit/LayoutTests/svg/text/bidi-text-query.svg
index afedda62b30d2162cbf03a6033d781db3a59e526..4e957f521f55dd8ec85765ea71e873aa97627c00 100644
--- a/third_party/WebKit/LayoutTests/svg/text/bidi-text-query.svg
+++ b/third_party/WebKit/LayoutTests/svg/text/bidi-text-query.svg
@@ -1,45 +1,26 @@
<?xml version="1.0" encoding="utf-8"?>
-<svg width="100%" height="100%" viewBox="0 0 480 360" xmlns="http://www.w3.org/2000/svg">
-<g font-family="Arial" font-size="18">
- <text x="10" y="50"><tspan direction="ltr" unicode-bidi="bidi-override">نشاط التدويل، W3C</tspan></text>
- <text x="10" y="80"><tspan direction="ltr" unicode-bidi="normal">نشاط التدويل، W3C</tspan></text>
- <text x="10" y="110" text-anchor="end" direction="rtl">W3C <tspan>نشاط التدويل،</tspan></text>
- <g id="container"/>
-
- <script type="text/javascript"><![CDATA[
- function highlightGlyph(text, index, color) {
- var extent = text.getExtentOfChar(index);
-
- // Highlight rect that we've selected using the extent information
- var rectElement = document.createElementNS("http://www.w3.org/2000/svg", "rect");
- rectElement.setAttribute("x", extent.x);
- rectElement.setAttribute("y", extent.y);
- rectElement.setAttribute("width", extent.width);
- rectElement.setAttribute("height", extent.height);
- rectElement.setAttribute("fill-opacity", "0.4");
- rectElement.setAttribute("fill", color);
- document.getElementById("container").appendChild(rectElement);
- // Output the start offset
- var textElement = document.createElementNS("http://www.w3.org/2000/svg", "text");
- textElement.setAttribute("x", extent.x + extent.width / 2);
- textElement.setAttribute("y", extent.y + extent.height + 5);
- textElement.setAttribute("text-anchor", "middle");
- textElement.setAttribute("font-size", 4);
- textElement.appendChild(document.createTextNode(index));
- document.getElementById("container").appendChild(textElement);
+<svg width="100%" height="100%" viewBox="0 0 480 360" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
+ <style>
+ .testTextRun {
+ font-family: Arial;
+ font-size: 18px;
+ }
+ #highlightContainer rect {
+ fill-opacity: 0.4;
}
+ #highlightContainer text {
+ font-family: Arial;
+ font-size: 4px;
+ }
+ </style>
- var colors = [ "red", "orange", "yellow", "green", "blue", "indigo", "violet"];
+ <text x="10" y="50" class="testTextRun"><tspan direction="ltr" unicode-bidi="bidi-override">نشاط التدويل، W3C</tspan></text>
+ <text x="10" y="80" class="testTextRun"><tspan direction="ltr" unicode-bidi="normal">نشاط التدويل، W3C</tspan></text>
+ <text x="10" y="110" class="testTextRun" text-anchor="end" direction="rtl">W3C <tspan>نشاط التدويل،</tspan></text>
+ <g id="highlightContainer"/>
- // Highlight each glyph with a semi-transparent rectangle and
- // a number corresponding to the queried character index.
- var textElements = document.querySelectorAll("text");
- for (var elemNum = 0; elemNum < textElements.length; ++elemNum) {
- var text = textElements[elemNum];
- var charCount = text.getNumberOfChars();
- for (var index = 0; index < charCount; ++index)
- highlightGlyph(text, index, colors[index % colors.length]);
- }
- ]]></script>
-</g>
+ <script xlink:href="resources/highlightGlyphs.js"></script>
+ <script>
+ highlightGlyphs(document.querySelectorAll('.testTextRun'), document.getElementById('highlightContainer'));
+ </script>
</svg>

Powered by Google App Engine
This is Rietveld 408576698