third_party/WebKit/LayoutTests/svg/text/surrogate-pair-queries.html - Issue 1847763002: Only synthesize grapheme widths once for surrogate pair characters

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/text/surrogate-pair-queries.html

Issue 1847763002: Only synthesize grapheme widths once for surrogate pair characters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviewer comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/text/resources/highlightGlyphs.js ('k') | third_party/WebKit/LayoutTests/svg/text/surrogate-pair-queries-expected.png » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <meta charset="utf8">

	3 <style>

	4 .testTextRun {

	5 font-size: 35px;

	6 }

	7 </style>

	8 <svg width="600px" height="500px" xmlns="http://www.w3.org/2000/svg">

	9 <g id="highlightContainer"/>

	10

	11 <!-- Two surrogate pairs -->

	12 <text x="50" y="50" class="testTextRun" font-family="cursive">🎶&#x1f 3b6;</text>

	13 <text x="200" y="50" class="testTextRun" font-family="serif">🎶&#x1f3 b6;</text>

	14 <text x="350" y="50" class="testTextRun" font-family="sans-serif">🎶& #x1f3b6;</text>

	15

	16 <!-- Surrogate pair with a combining diacritic -->

	17 <text x="50" y="125" class="testTextRun" font-family="cursive">𐐷&#x0 30c; v̌</text>

	18 <text x="200" y="125" class="testTextRun" font-family="serif">𐐷&#x03 0c; v̌</text>

	19 <text x="350" y="125" class="testTextRun" font-family="sans-serif">𐐷 ̌ v̌</text>

	20

	21 <!-- Surrogate pair with a combining diacritic in RTL -->

	22 <text x="150" y="250" class="testTextRun" direction="rtl" font-family="cursi ve">🎶𐐷̌🎶</text>

	23 <text x="300" y="250" class="testTextRun" direction="rtl" font-family="serif ">🎶𐐷̌🎶</text>

	24 <text x="450" y="250" class="testTextRun" direction="rtl" font-family="sans- serif">🎶𐐷̌🎶</text>

	25

	26 <!-- Surrogate pair with a combining diacritic in RTL with override -->

	27 <text x="150" y="350" class="testTextRun" direction="rtl" unicode-bidi="bidi -override" font-family="cursive">🎶𐐷̌🎶</text>

	28 <text x="300" y="350" class="testTextRun" direction="rtl" unicode-bidi="bidi -override" font-family="serif">🎶𐐷̌🎶</text>

	29 <text x="450" y="350" class="testTextRun" direction="rtl" unicode-bidi="bidi -override" font-family="sans-serif">🎶𐐷̌🎶</text>

	30 </svg>

	31 <script src="resources/highlightGlyphs.js"></script>

	32 <script>

	33 highlightGlyphs(document.querySelectorAll('.testTextRun'), highlightContaine r);

	34 </script>

OLD	NEW