Mark executables to be compatible with Windows 8.1

Mark executables to be compatible with Windows 8.1

Starting with Windows 8.1, GetVersion(Ex) APIs always
return "6.2" even on Windows 8.1 (whose true version
is NT 6.3) when the application manifest does not
have a specific compatibility statement.

As a result, the user agent string becomes
"Mozilla/5.0 (Windows NT 6.2; WOW64) ..." even on
Windows 8.1.

This CL fixes the issue.

See the following document for the background
information.
http://msdn.microsoft.com/en-us/library/windows/desktop/dn302074.aspx

BUG=259228
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212209

[cpu_(ooo_6.6-7.5), 2013-07-12 19:49:48]

lgtm

but wait for grt@ lgtm as well.

[grt (UTC plus 2), 2013-07-15 19:26:58]

On 2013/07/12 19:49:48, cpu wrote:
> lgtm
> 
> but wait for grt@ lgtm as well.

LGTM, but I fear that this will be a whack-a-mole game. It would be nice if we
had a centralized way to ensure that all .exe manifests included this new stanza
(e.g., src/win8/test uses base::win::GetVersion, but there's no guarantee that
all .exes linking test_support_win8 include the new stanza).

[Yohei Yukawa, 2013-07-16 14:52:22]

On 2013/07/15 19:26:58, grt wrote:
> On 2013/07/12 19:49:48, cpu wrote:
> > lgtm
> > 
> > but wait for grt@ lgtm as well.
> 
> LGTM, but I fear that this will be a whack-a-mole game. It would be nice if we
> had a centralized way to ensure that all .exe manifests included this new
stanza
> (e.g., src/win8/test uses base::win::GetVersion, but there's no guarantee that
> all .exes linking test_support_win8 include the new stanza).

Agreed. I filed http://crbug.com/260692 and made a initial implementation for it
as https://codereview.chromium.org/19275010 . So I believe we can embed the
manifest
more easily in a centralized way soon.

Regarding this CL, I'd like to commit this as a minimum fix of the original
issue.
Please let me know if you think we should fix the issue by
https://codereview.chromium.org/19275010

Thanks!

[grt (UTC plus 2), 2013-07-16 15:02:36]

On 2013/07/16 14:52:22, Yohei Yukawa wrote:
> On 2013/07/15 19:26:58, grt wrote:
> > On 2013/07/12 19:49:48, cpu wrote:
> > > lgtm
> > > 
> > > but wait for grt@ lgtm as well.
> > 
> > LGTM, but I fear that this will be a whack-a-mole game. It would be nice if
we
> > had a centralized way to ensure that all .exe manifests included this new
> stanza
> > (e.g., src/win8/test uses base::win::GetVersion, but there's no guarantee
that
> > all .exes linking test_support_win8 include the new stanza).
> 
> Agreed. I filed http://crbug.com/260692 and made a initial implementation for
it
> as https://codereview.chromium.org/19275010 . So I believe we can embed the
> manifest
> more easily in a centralized way soon.
> 
> Regarding this CL, I'd like to commit this as a minimum fix of the original
> issue.
> Please let me know if you think we should fix the issue by
> https://codereview.chromium.org/19275010
> 
> Thanks!

lgtm to land this as-is while working on something more robust. thanks.

[Yohei Yukawa, 2013-07-16 16:22:23]

+jochen@ for the OWNER review of content/shell/app/.
Could you take a look?

[jochen (gone - plz use gerrit), 2013-07-17 11:31:36]

lgtm

[commit-bot: I haz the power, 2013-07-17 11:47:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Yukawa@chromium.org/18477012/1

[commit-bot: I haz the power, 2013-07-17 11:47:06]

Failed to apply patch for chrome/app/chrome.exe.manifest:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/app/chrome.exe.manifest
  Hunk #1 FAILED at 9.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/app/chrome.exe.manifest.rej

Patch:       chrome/app/chrome.exe.manifest
Index: chrome/app/chrome.exe.manifest
diff --git a/chrome/app/chrome.exe.manifest b/chrome/app/chrome.exe.manifest
index
ba2f19180e38155b7f9384a6c2c0e5a7189e70e0..27fd0f274f9c6d94bc2a04a1658f191785c9e1f8
100644
--- a/chrome/app/chrome.exe.manifest
+++ b/chrome/app/chrome.exe.manifest
@@ -9,6 +9,8 @@
       <supportedOS Id="{35138b9a-5d96-4fbd-8e2d-a2440225f93a}"/>
       <!--The ID below indicates application support for Windows 8 -->
       <supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}"/>
+      <!--The ID below indicates application support for Windows 8.1 -->
+      <supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
     </application>
   </compatibility>

[commit-bot: I haz the power, 2013-07-17 14:24:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Yukawa@chromium.org/18477012/14005

[commit-bot: I haz the power, 2013-07-17 19:53:59]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-07-18 00:43:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Yukawa@chromium.org/18477012/14005

[commit-bot: I haz the power, 2013-07-18 02:19:13]

Change committed as 212209