Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1847683004: Mojom compiler backend: Stop re-computing interface version numbers and consume method declaration o (Closed)

Created:
4 years, 8 months ago by rudominer
Modified:
4 years, 8 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojom compiler backend: Stop re-computing interface version numbers and consume method declaration order. The current version of an interface is now being computed in the frontend so in this patch we stop re-computing this value in the backend and simply consume the version from the intermediate representation. Similarly we stop parsing the "MinVersion" attribute for a method and consume the parsed value from the intermediate representation. Finally we sort the methods of an interface by declaration order instead of by ordinal order. A method's ordinal is specified in the |ordinal| field so with this change the generators will be able to know both the ordinal and the declaration order. BUG=#713 R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f444558244bac885e7c9644608c010b25a9bfddd

Patch Set 1 : More tests #

Patch Set 2 : Rebasing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -29 lines) Patch
M mojo/public/tools/bindings/pylib/mojom/generate/generator.py View 1 chunk +0 lines, -15 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py View 4 chunks +8 lines, -12 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator_unittest.py View 7 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
rudominer
Hi Alex, ptal.
4 years, 8 months ago (2016-03-31 18:48:56 UTC) #6
azani
lgtm
4 years, 8 months ago (2016-03-31 19:02:18 UTC) #7
rudominer
4 years, 8 months ago (2016-03-31 19:12:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
f444558244bac885e7c9644608c010b25a9bfddd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698