Issue 1847683002: Fix CompilerStats aggregation: do not aggregate if there is no mutator thread (isolate shutting dow…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1847683002: Fix CompilerStats aggregation: do not aggregate if there is no mutator thread (isolate shutting dow… (Closed)

Created:
4 years, 8 months ago by srdjan

Modified:
4 years, 8 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix CompilerStats aggregation: do not aggregate if there is no mutator thread (isolate shutting down). Disable background compilation in Profiler_StringInterpolation. BUG= Committed: https://github.com/dart-lang/sdk/commit/a7a7a5be55a561ead1a70ed34ca10777f18683a2

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	runtime/vm/compiler.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
	M	runtime/vm/profiler_test.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

srdjan

Committed patchset #2 (id:20001) manually as a7a7a5be55a561ead1a70ed34ca10777f18683a2 (presubmit successful).

4 years, 8 months ago (2016-03-30 21:24:19 UTC) #4

Message was sent while issue was closed.

lgtm