Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1847653002: gtm: Stop compiling two unused files. (Closed)

Created:
4 years, 8 months ago by erikchen
Modified:
4 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gtm: Stop compiling two unused files. The files used methods deprecated in OS X 10.7. BUG=592663 Committed: https://crrev.com/46cc2e824110f888200f0f16581e09199bc31a0e Cr-Commit-Position: refs/heads/master@{#384075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/google_toolbox_for_mac/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
erikchen
rsesek: Please review.
4 years, 8 months ago (2016-03-30 19:04:05 UTC) #2
Robert Sesek
lgtm
4 years, 8 months ago (2016-03-30 19:20:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847653002/1
4 years, 8 months ago (2016-03-30 19:21:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 20:21:43 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 20:23:18 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/46cc2e824110f888200f0f16581e09199bc31a0e
Cr-Commit-Position: refs/heads/master@{#384075}

Powered by Google App Engine
This is Rietveld 408576698