Fix more strong mode errors in analyzer

Fix more strong mode errors in analyzer

R=rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/e531f01e73bea80d33d531d2502a3044721f1433

[Brian Wilkerson, 2016-03-30 19:00:56]

brianwilkerson@google.com changed reviewers:
+ jmesserly@google.com, leafp@google.com, rnystrom@google.com

[Brian Wilkerson, 2016-03-30 19:00:57]

This is a subset of the changes from the previous CL (there are some issues that
I want to explore fixing differently) and should be free of formatting / sorting
noise.

[Bob Nystrom, 2016-03-30 19:59:05]

LGTM!

https://codereview.chromium.org/1847633002/diff/40001/pkg/analyzer/test/gener...
File pkg/analyzer/test/generated/parser_test.dart (right):

https://codereview.chromium.org/1847633002/diff/40001/pkg/analyzer/test/gener...
pkg/analyzer/test/generated/parser_test.dart:3503:
[ParserErrorCode.MISSING_IDENTIFIER]) as List<Expression>;
Do you think it might be worth making parse4() itself generic and have it do the
cast for you?

[Brian Wilkerson, 2016-03-31 00:23:11]

https://codereview.chromium.org/1847633002/diff/40001/pkg/analyzer/test/gener...
File pkg/analyzer/test/generated/parser_test.dart (right):

https://codereview.chromium.org/1847633002/diff/40001/pkg/analyzer/test/gener...
pkg/analyzer/test/generated/parser_test.dart:3503:
[ParserErrorCode.MISSING_IDENTIFIER]) as List<Expression>;
I'm open to doing that if you want.

Longer term I'd like to define the public API for the parser, change the
existing private methods to being public, and get rid of the helper methods
(like `parse4`) that only serve to allow us to invoke private methods. Given
that, Im not sure it's worth the effort.

[Bob Nystrom, 2016-03-31 16:02:05]

On 2016/03/31 00:23:11, Brian Wilkerson wrote:
>
https://codereview.chromium.org/1847633002/diff/40001/pkg/analyzer/test/gener...
> File pkg/analyzer/test/generated/parser_test.dart (right):
> 
>
https://codereview.chromium.org/1847633002/diff/40001/pkg/analyzer/test/gener...
> pkg/analyzer/test/generated/parser_test.dart:3503:
> [ParserErrorCode.MISSING_IDENTIFIER]) as List<Expression>;
> Longer term I'd like to define the public API for the parser, change the
> existing private methods to being public, and get rid of the helper methods
> (like `parse4`) that only serve to allow us to invoke private methods. Given
> that, Im not sure it's worth the effort.

Totally agree, that sounds great.

[Brian Wilkerson, 2016-03-31 20:30:17]

Description was changed from

==========
Fix more strong mode errors in analyzer
==========

to

==========
Fix more strong mode errors in analyzer

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e531f01e73bea80d33d531d2502a3044721f1433
==========

[Brian Wilkerson, 2016-03-31 20:30:22]

Committed patchset #3 (id:40001) manually as
e531f01e73bea80d33d531d2502a3044721f1433 (presubmit successful).