Issue 1847623002: Ensure deoptimizing frames have a valid pc marker before deferred materialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1847623002: Ensure deoptimizing frames have a valid pc marker before deferred materialization. (Closed)

Created:
4 years, 8 months ago by rmacnak

Modified:
4 years, 8 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Ensure deoptimizing frames have a valid pc marker before deferred materialization. BUG=http://dartbug.com/26131 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/ba608694b7aa481b8e62f6aeb22ee388646b4f0b

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -3 lines)			Patch
M	runtime/vm/code_generator.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/deopt_instructions.cc	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	runtime/vm/stub_code.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

4 years, 8 months ago (2016-03-30 20:11:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ba608694b7aa481b8e62f6aeb22ee388646b4f0b (presubmit successful).