Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1847583004: Move the fpdfsdk/include/javascript folder (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move the fpdfsdk/include/javascript folder This CL splits the IJavaScript.h file into the two inner classes and puts them in the fpdfsdk/javascript folder. Committed: https://pdfium.googlesource.com/pdfium/+/64376be4aac4710848b36b823fd98aae75095336

Patch Set 1 #

Total comments: 10

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -1201 lines) Patch
M BUILD.gn View 1 3 chunks +6 lines, -5 lines 0 comments Download
M fpdfsdk/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_app.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fsdk_actionhandler.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/fsdk_baseform.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/fsdk_mgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 2 chunks +1 line, -1 line 0 comments Download
M fpdfsdk/include/fxedit/fxet_edit.h View 1 6 chunks +0 lines, -13 lines 0 comments Download
D fpdfsdk/include/javascript/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D fpdfsdk/include/javascript/IJavaScript.h View 1 chunk +0 lines, -166 lines 0 comments Download
M fpdfsdk/javascript/Consts.h View 1 10 chunks +0 lines, -22 lines 0 comments Download
M fpdfsdk/javascript/Consts.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/javascript/Document.cpp View 1 2 3 chunks +2 lines, -8 lines 0 comments Download
M fpdfsdk/javascript/Field.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/Icon.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/JS_Context.h View 1 1 chunk +0 lines, -137 lines 0 comments Download
M fpdfsdk/javascript/JS_Context.cpp View 1 1 chunk +0 lines, -284 lines 0 comments Download
M fpdfsdk/javascript/JS_EventHandler.cpp View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M fpdfsdk/javascript/JS_GlobalData.cpp View 1 2 chunks +0 lines, -5 lines 0 comments Download
M fpdfsdk/javascript/JS_Object.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/JS_Object.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/JS_Runtime.h View 1 1 chunk +0 lines, -92 lines 0 comments Download
M fpdfsdk/javascript/JS_Runtime.cpp View 1 1 chunk +0 lines, -334 lines 0 comments Download
M fpdfsdk/javascript/JS_Runtime_Stub.cpp View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/JS_Value.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/PublicMethods.cpp View 1 2 9 chunks +6 lines, -14 lines 0 comments Download
M fpdfsdk/javascript/app.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
A + fpdfsdk/javascript/cjs_context.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
A + fpdfsdk/javascript/cjs_context.cpp View 1 1 chunk +2 lines, -5 lines 0 comments Download
A + fpdfsdk/javascript/cjs_runtime.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + fpdfsdk/javascript/cjs_runtime.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download
M fpdfsdk/javascript/color.cpp View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M fpdfsdk/javascript/console.cpp View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M fpdfsdk/javascript/event.cpp View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M fpdfsdk/javascript/global.cpp View 1 2 1 chunk +1 line, -4 lines 0 comments Download
A + fpdfsdk/javascript/ijs_context.h View 2 chunks +6 lines, -38 lines 0 comments Download
A fpdfsdk/javascript/ijs_runtime.h View 1 chunk +48 lines, -0 lines 0 comments Download
M fpdfsdk/javascript/report.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/util.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M pdfium.gyp View 1 4 chunks +6 lines, -5 lines 0 comments Download
M samples/image_diff_png.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxjse/runtime.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-03-31 16:11:51 UTC) #2
Tom Sepez
https://codereview.chromium.org/1847583004/diff/1/fpdfsdk/javascript/JS_Context.cpp File fpdfsdk/javascript/JS_Context.cpp (right): https://codereview.chromium.org/1847583004/diff/1/fpdfsdk/javascript/JS_Context.cpp#newcode7 fpdfsdk/javascript/JS_Context.cpp:7: #include "fpdfsdk/javascript/JS_Context.h" rename this file to cjs_context.cpp while we're ...
4 years, 8 months ago (2016-03-31 16:23:28 UTC) #3
dsinclair
https://codereview.chromium.org/1847583004/diff/1/fpdfsdk/javascript/JS_Context.cpp File fpdfsdk/javascript/JS_Context.cpp (right): https://codereview.chromium.org/1847583004/diff/1/fpdfsdk/javascript/JS_Context.cpp#newcode7 fpdfsdk/javascript/JS_Context.cpp:7: #include "fpdfsdk/javascript/JS_Context.h" On 2016/03/31 16:23:28, Tom Sepez wrote: > ...
4 years, 8 months ago (2016-03-31 17:00:41 UTC) #4
Tom Sepez
lgtm
4 years, 8 months ago (2016-03-31 22:00:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847583004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847583004/40001
4 years, 8 months ago (2016-04-01 03:03:09 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 03:03:27 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/64376be4aac4710848b36b823fd98aae7509...

Powered by Google App Engine
This is Rietveld 408576698