Fix setComposingText when newCursorPosition != 1

third_party/WebKit/Source/core/editing/PlainTextRangeTest.cpp

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/editing/PlainTextRange.h"
+
+#include "core/dom/Element.h"
+#include "core/dom/Range.h"
+#include "core/editing/FrameSelection.h"
+#include "core/editing/InputMethodController.h"
+#include "core/frame/LocalFrame.h"
+#include "core/html/HTMLDocument.h"
+#include "core/html/HTMLInputElement.h"
+#include "core/testing/DummyPageHolder.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace blink {
+
+class PlainTextRangeTest : public ::testing::Test {
+protected:
+    HTMLDocument& document() const { return *m_document; }
+    LocalFrame& frame() const { return m_dummyPageHolder->frame(); }
+    Element* insertHTMLElement(const char* elementCode, const char* elementId);
+
+private:
+    void SetUp() override;
+
+    OwnPtr<DummyPageHolder> m_dummyPageHolder;
+    Persistent<HTMLDocument> m_document;
+};
+
+void PlainTextRangeTest::SetUp()
+{
+    m_dummyPageHolder = DummyPageHolder::create(IntSize(800, 600));
+    m_document = toHTMLDocument(&m_dummyPageHolder->document());
+    ASSERT(m_document);
+}
+
+Element* PlainTextRangeTest::insertHTMLElement(
+    const char* elementCode, const char* elementId)
+{
+    document().write(elementCode);
+    document().updateLayout();
+    Element* element = document().getElementById(elementId);
+    element->focus();
+    return element;
+}
+
+TEST_F(PlainTextRangeTest, CreateDifferentRanges)

[Changwan Ryu, 2016/04/05 07:50:37]

CreateRange?

[yabinh, 2016/04/05 08:06:42]

Acknowledged.

+{
+    // Since the cursor never exceeds the left boundary, our test should focus on right boundary cases.
+    HTMLInputElement* input = toHTMLInputElement(
+        insertHTMLElement("<input id='sample'>", "sample"));
+
+    input->setValue("hello");
+    Element* rootEditableElement = frame().selection().rootEditableElement();
+    EXPECT_TRUE(rootEditableElement);
+
+    // Start and End are on thEphemeralRangee right boundary
+    EphemeralRange range = PlainTextRange(5, 5).createRange(*rootEditableElement);
+    EXPECT_EQ(5, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(5, range.endPosition().computeOffsetInContainerNode());
+
+    // Start is on the right boundary, and End exceeds right boundary
+    range = PlainTextRange(5, 10).createRange(*rootEditableElement);
+    EXPECT_EQ(5, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(5, range.endPosition().computeOffsetInContainerNode());
+
+    // Start and End exceed the right boundary
+    range = PlainTextRange(10, 10).createRange(*rootEditableElement);
+    EXPECT_EQ(5, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(5, range.endPosition().computeOffsetInContainerNode());
+
+    input->setValue("");
+    rootEditableElement = frame().selection().rootEditableElement();
+    EXPECT_TRUE(rootEditableElement);
+
+    // Start and End are on thEphemeralRangee right boundary
+    range = PlainTextRange(0, 0).createRange(*rootEditableElement);
+    EXPECT_EQ(0, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(0, range.endPosition().computeOffsetInContainerNode());
+
+    // Start is on the right boundary, and End exceeds right boundary
+    range = PlainTextRange(0, 10).createRange(*rootEditableElement);
+    EXPECT_EQ(0, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(0, range.endPosition().computeOffsetInContainerNode());
+
+    // Start and End exceed the right boundary
+    range = PlainTextRange(10, 10).createRange(*rootEditableElement);
+    EXPECT_EQ(0, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(0, range.endPosition().computeOffsetInContainerNode());
+}
+
+TEST_F(PlainTextRangeTest, CreateDifferentRangesForSelection)

[Changwan Ryu, 2016/04/05 07:50:37]

CreateRangeForSelection should be enough?

Could you also try to write tests for contenteditable?

[yabinh, 2016/04/05 08:06:42]

Acknowledged.

+{
+    // Since the cursor never exceeds the left boundary, our test should focus on right boundary cases.
+    HTMLInputElement* input = toHTMLInputElement(
+        insertHTMLElement("<input id='sample'>", "sample"));
+
+    input->setValue("hello");
+    Element* rootEditableElement = frame().selection().rootEditableElement();
+    EXPECT_TRUE(rootEditableElement);
+
+    // Start and End are on the right boundary

[Changwan Ryu, 2016/04/05 07:50:37]

no need to capitalize E and you need to add a period at the end of a full
sentence.

[yabinh, 2016/04/05 08:06:41]

Acknowledged.

+    EphemeralRange range = PlainTextRange(5, 5).createRangeForSelection(*rootEditableElement);
+    EXPECT_EQ(5, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(5, range.endPosition().computeOffsetInContainerNode());
+
+    // Start is on the right boundary, and End exceeds right boundary
+    range = PlainTextRange(5, 10).createRangeForSelection(*rootEditableElement);
+    EXPECT_EQ(5, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(5, range.endPosition().computeOffsetInContainerNode());
+
+    // Start and End exceed the right boundary
+    range = PlainTextRange(10, 10).createRangeForSelection(*rootEditableElement);
+    EXPECT_EQ(5, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(5, range.endPosition().computeOffsetInContainerNode());
+
+    input->setValue("");
+    rootEditableElement = frame().selection().rootEditableElement();
+    EXPECT_TRUE(rootEditableElement);
+
+    // Start and End are on the right boundary
+    range = PlainTextRange(0, 0).createRangeForSelection(*rootEditableElement);
+    EXPECT_EQ(0, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(0, range.endPosition().computeOffsetInContainerNode());
+
+    // Start is on the right boundary, and End exceeds right boundary
+    range = PlainTextRange(0, 10).createRangeForSelection(*rootEditableElement);
+    EXPECT_EQ(0, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(0, range.endPosition().computeOffsetInContainerNode());
+
+    // Start and End exceed the right boundary
+    range = PlainTextRange(10, 10).createRangeForSelection(*rootEditableElement);
+    EXPECT_EQ(0, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(0, range.endPosition().computeOffsetInContainerNode());
+}
+}