Fix setComposingText when newCursorPosition != 1

third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/InputMethodController.h"
 
 #include "core/dom/Element.h"
 #include "core/dom/Range.h"
 #include "core/editing/FrameSelection.h"
 #include "core/frame/LocalFrame.h"
@@ skipping 28 matching lines @@
 Element* InputMethodControllerTest::insertHTMLElement(
     const char* elementCode, const char* elementId)
 {
     document().write(elementCode);
     document().updateLayout();
     Element* element = document().getElementById(elementId);
     element->focus();
     return element;
 }
 
+TEST_F(InputMethodControllerTest, CreateDifferentRanges)
+{
+    HTMLInputElement* input = toHTMLInputElement(
+        insertHTMLElement("<input id='sample'>", "sample"));
+
+    input->setValue("hello");
+    Element* rootEditableElement = frame().selection().rootEditableElement();
+    EXPECT_TRUE(rootEditableElement);
+
+    // In InputMethodController::setComposition, we are sure that End >= Start >= 0. Our tests can base on this fact.
+    // Start and End are on the left boundary
+    EphemeralRange range = PlainTextRange(0, 0).createRange(*rootEditableElement);
+    EXPECT_EQ(0u, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(0u, range.endPosition().computeOffsetInContainerNode());
+
+    // Start is on the left boundary, and End is on the right boundary

[Changwan Ryu, 2016/04/04 06:23:13]

The below code seems to belong to PlainTextRange tests.

[yabinh, 2016/04/04 08:31:51]

OK. I'll create a new file to put the test.

+    range = PlainTextRange(0, 5).createRange(*rootEditableElement);
+    EXPECT_EQ(0u, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(5u, range.endPosition().computeOffsetInContainerNode());
+
+    // Start is on the left boundary, and End exceeds right boundary
+    range = PlainTextRange(0, 10).createRange(*rootEditableElement);
+    EXPECT_EQ(0u, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(5u, range.endPosition().computeOffsetInContainerNode());
+
+    // Start and End are on the right boundary
+    range = PlainTextRange(5, 5).createRange(*rootEditableElement);
+    EXPECT_EQ(5u, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(5u, range.endPosition().computeOffsetInContainerNode());
+
+    // Start is on the right boundary, and End exceeds right boundary
+    range = PlainTextRange(5, 10).createRange(*rootEditableElement);
+    EXPECT_EQ(5u, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(5u, range.endPosition().computeOffsetInContainerNode());
+
+    // Start and End exceed the right boundary
+    range = PlainTextRange(10, 10).createRange(*rootEditableElement);
+    EXPECT_EQ(5u, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(5u, range.endPosition().computeOffsetInContainerNode());
+}
+
+TEST_F(InputMethodControllerTest, CreateDifferentRangesForSelection)
+{
+    HTMLInputElement* input = toHTMLInputElement(
+        insertHTMLElement("<input id='sample'>", "sample"));
+
+    input->setValue("hello");
+    Element* rootEditableElement = frame().selection().rootEditableElement();
+    EXPECT_TRUE(rootEditableElement);
+
+    // In InputMethodController::setComposition, we are sure that End >= Start >= 0. Our tests can base on this fact.
+    // Start and End are on the left boundary
+    EphemeralRange range = PlainTextRange(0, 0).createRangeForSelection(*rootEditableElement);
+    EXPECT_EQ(0u, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(0u, range.endPosition().computeOffsetInContainerNode());
+
+    // Start is on the left boundary, and End is on the right boundary
+    range = PlainTextRange(0, 5).createRangeForSelection(*rootEditableElement);
+    EXPECT_EQ(0u, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(5u, range.endPosition().computeOffsetInContainerNode());
+
+    // Start is on the left boundary, and End exceeds right boundary
+    range = PlainTextRange(0, 10).createRangeForSelection(*rootEditableElement);
+    EXPECT_EQ(0u, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(5u, range.endPosition().computeOffsetInContainerNode());
+
+    // Start and End are on the right boundary
+    range = PlainTextRange(5, 5).createRangeForSelection(*rootEditableElement);
+    EXPECT_EQ(5u, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(5u, range.endPosition().computeOffsetInContainerNode());
+
+    // Start is on the right boundary, and End exceeds right boundary
+    range = PlainTextRange(5, 10).createRangeForSelection(*rootEditableElement);
+    EXPECT_EQ(5u, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(5u, range.endPosition().computeOffsetInContainerNode());
+
+    // Start and End exceed the right boundary
+    range = PlainTextRange(10, 10).createRangeForSelection(*rootEditableElement);
+    EXPECT_EQ(5u, range.startPosition().computeOffsetInContainerNode());
+    EXPECT_EQ(5u, range.endPosition().computeOffsetInContainerNode());
+}
+
 TEST_F(InputMethodControllerTest, BackspaceFromEndOfInput)
 {
     HTMLInputElement* input = toHTMLInputElement(
         insertHTMLElement("<input id='sample'>", "sample"));
 
     input->setValue("fooX");
     controller().setEditableSelectionOffsets(PlainTextRange(4, 4));
     EXPECT_STREQ("fooX", input->value().utf8().data());
     controller().extendSelectionAndDelete(0, 0);
     EXPECT_STREQ("fooX", input->value().utf8().data());
@@ skipping 125 matching lines @@
 
     Vector<CompositionUnderline> underlines;
     underlines.append(CompositionUnderline(0, 5, Color(255, 0, 0), false, 0));
     controller().setComposition("foo", underlines, 0, 3);
     controller().confirmComposition();
 
     EXPECT_STREQ("foo", input->value().utf8().data());
 }
 
 } // namespace blink