Update SkMergeImageFilter to sk_sp

Update SkMergeImageFilter to sk_sp

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1847583002

Committed: https://skia.googlesource.com/skia/+/2238c9dbca4b791edc512957728a18ce14d55912

[robertphillips, 2016-03-30 16:46:14]

Description was changed from

==========
Update SkMergeImageFilter to sk_sp
==========

to

==========
Update SkMergeImageFilter to sk_sp
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-30 16:46:52]

Description was changed from

==========
Update SkMergeImageFilter to sk_sp
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Update SkMergeImageFilter to sk_sp

TBR=reed@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-30 16:46:53]

robertphillips@google.com changed reviewers:
+ fmalita@chromium.org, reed@google.com

[robertphillips, 2016-03-30 17:22:58]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 17:23:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847583002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847583002/20001

[commit-bot: I haz the power, 2016-03-30 17:38:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 17:38:29]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-03-30 18:28:47]

https://codereview.chromium.org/1847583002/diff/20001/include/core/SkImageFil...
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/1847583002/diff/20001/include/core/SkImageFil...
include/core/SkImageFilter.h:310: sk_sp<SkImageFilter>  getInput(int index)
const { return fInputs[index]; }
Not sure about this one: AFAIU, the general plan is to stick to raw pointers for
getters (e.g. SkPaint::getShader & friends).  Is this normally used for grabbing
a ref?  Should it stay a rawptr or maybe rename to refInput()?

[robertphillips, 2016-03-30 19:02:27]

https://codereview.chromium.org/1847583002/diff/20001/include/core/SkImageFil...
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/1847583002/diff/20001/include/core/SkImageFil...
include/core/SkImageFilter.h:310: sk_sp<SkImageFilter>  getInput(int index)
const { return fInputs[index]; }
In this case 'getInput' and 'inputs' are only called from the
SkImageFilter::CreateProc methods. In this use case the results will always just
be passed to a Make() factory that takes a smart pointer.

Returning raw pointers here mean we'll just have to rewrap them in the
CreateProc methods.

[f(malita), 2016-03-30 19:08:53]

lgtm

https://codereview.chromium.org/1847583002/diff/20001/include/core/SkImageFil...
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/1847583002/diff/20001/include/core/SkImageFil...
include/core/SkImageFilter.h:310: sk_sp<SkImageFilter>  getInput(int index)
const { return fInputs[index]; }
On 2016/03/30 19:02:27, robertphillips wrote:
> In this case 'getInput' and 'inputs' are only called from the
> SkImageFilter::CreateProc methods. In this use case the results will always
just
> be passed to a Make() factory that takes a smart pointer.
> 
> Returning raw pointers here mean we'll just have to rewrap them in the
> CreateProc methods.

Makes sense (plus I now see it's proteceted).

[robertphillips, 2016-03-30 19:45:46]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 19:45:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847583002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847583002/40001

[commit-bot: I haz the power, 2016-03-30 20:05:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 20:05:31]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-03-30 20:33:14]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-03-30 20:33:15]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1847583002/#ps40001
(title: "update to To")

[commit-bot: I haz the power, 2016-03-30 20:33:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847583002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847583002/40001

[commit-bot: I haz the power, 2016-03-30 20:34:19]

Description was changed from

==========
Update SkMergeImageFilter to sk_sp

TBR=reed@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Update SkMergeImageFilter to sk_sp

TBR=reed@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/2238c9dbca4b791edc512957728a18ce14d55912
==========

[commit-bot: I haz the power, 2016-03-30 20:34:20]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/2238c9dbca4b791edc512957728a18ce14d55912