Use the ChromeBrowserInitializer on incoming notification intents

Use the ChromeBrowserInitializer on incoming notification intents

This removes the need for this entry point to set up command line flags
and the PathUtils directory prefix ourselves.

BUG=599059
Committed: https://crrev.com/3c2d44918c2a4b5a6f829f70ca4528f23bb8c9be
Cr-Commit-Position: refs/heads/master@{#384292}

[Peter Beverloo, 2016-03-30 18:09:19]

peter@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[Peter Beverloo, 2016-03-30 18:09:19]

+mvanouwerkerk for review

[Michael van Ouwerkerk, 2016-03-31 10:00:04]

These changes look fine, but the test is crashing. Not sure why, maybe it needs
to explicitly jump to the UI thread?

https://codereview.chromium.org/1847573003/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerIntentTest.java
(right):

https://codereview.chromium.org/1847573003/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerIntentTest.java:125:
* The created intend does not carry significant data and is expected to fail,
but has to be
s/intend/intent/

https://codereview.chromium.org/1847573003/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerIntentTest.java:134:
final Context context =
getInstrumentation().getTargetContext().getApplicationContext();
tiny nit: no need for |final| here as it is not used in an anonymous class. We
don't mark arguments or locals |final| unless needed.

https://codereview.chromium.org/1847573003/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerIntentTest.java:156:
assertNotNull(NotificationUIManager.getInstanceForTests());
Perhaps for symmetry with the start of this test, add:
assertTrue("The native library should be loaded now",
LibraryLoader.isInitialized());

[Peter Beverloo, 2016-03-31 15:12:17]

Crash fixed, comments addressed; PTAL!

https://codereview.chromium.org/1847573003/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerIntentTest.java
(right):

https://codereview.chromium.org/1847573003/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerIntentTest.java:125:
* The created intend does not carry significant data and is expected to fail,
but has to be
On 2016/03/31 10:00:04, Michael van Ouwerkerk wrote:
> s/intend/intent/

Done.

https://codereview.chromium.org/1847573003/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerIntentTest.java:134:
final Context context =
getInstrumentation().getTargetContext().getApplicationContext();
On 2016/03/31 10:00:04, Michael van Ouwerkerk wrote:
> tiny nit: no need for |final| here as it is not used in an anonymous class. We
> don't mark arguments or locals |final| unless needed.

Done.

https://codereview.chromium.org/1847573003/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerIntentTest.java:156:
assertNotNull(NotificationUIManager.getInstanceForTests());
On 2016/03/31 10:00:04, Michael van Ouwerkerk wrote:
> Perhaps for symmetry with the start of this test, add:
> assertTrue("The native library should be loaded now",
> LibraryLoader.isInitialized());

Done.

[Michael van Ouwerkerk, 2016-03-31 15:15:34]

lgtm

[Michael van Ouwerkerk, 2016-03-31 15:15:41]

The CQ bit was checked by mvanouwerkerk@chromium.org

[commit-bot: I haz the power, 2016-03-31 15:15:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847573003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847573003/40001

[commit-bot: I haz the power, 2016-03-31 15:58:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-31 15:59:44]

Description was changed from

==========
Use the ChromeBrowserInitializer on incoming notification intents

This removes the need for this entry point to set up command line flags
and the PathUtils directory prefix ourselves.

BUG=599059
==========

to

==========
Use the ChromeBrowserInitializer on incoming notification intents

This removes the need for this entry point to set up command line flags
and the PathUtils directory prefix ourselves.

BUG=599059

Committed: https://crrev.com/3c2d44918c2a4b5a6f829f70ca4528f23bb8c9be
Cr-Commit-Position: refs/heads/master@{#384292}
==========

[commit-bot: I haz the power, 2016-03-31 15:59:45]

Patchset 3 (id:??) landed as
https://crrev.com/3c2d44918c2a4b5a6f829f70ca4528f23bb8c9be
Cr-Commit-Position: refs/heads/master@{#384292}