Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Issue 1847563003: PPC: [wasm] Int64Lowering of Int64Mul. (Closed)

Created:
4 years, 8 months ago by MTBrandyberry
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [wasm] Int64Lowering of Int64Mul. Port 40bdbef975779e41a7e81d3748342dd7da52977f Original commit message: Int64Mul is lowered to a new turbofan operator, Int32MulPair. The new operator takes 4 inputs an generates 2 outputs. The inputs are the low word of the left input, high word of the left input, the low word of the right input, and high word of the right input. The ouputs are the low and high word of the result of the multiplication. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/20ff44f07f9397dea765520725d54ee627dcbb64 Cr-Commit-Position: refs/heads/master@{#35143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-codes-ppc.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-scheduler-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
PTAL
4 years, 8 months ago (2016-03-30 21:42:04 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847563003/1
4 years, 8 months ago (2016-03-30 21:42:19 UTC) #3
JoranSiu
On 2016/03/30 21:42:19, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 8 months ago (2016-03-30 22:01:51 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 22:04:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847563003/1
4 years, 8 months ago (2016-03-30 22:31:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 22:33:54 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 22:34:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20ff44f07f9397dea765520725d54ee627dcbb64
Cr-Commit-Position: refs/heads/master@{#35143}

Powered by Google App Engine
This is Rietveld 408576698