Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1847533004: mac: Bump the deployment target to OS X 10.7. (Closed)

Created:
4 years, 8 months ago by erikchen
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Bump the deployment target to OS X 10.7. BUG=592663 Committed: https://crrev.com/4bdf946cb5e01a3165fbe4e64ca15ff5aaa2ef5f Cr-Commit-Position: refs/heads/master@{#385003}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comments from thakis. #

Patch Set 3 : Comments from thakis. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M build/common.gypi View 1 2 2 chunks +3 lines, -12 lines 0 comments Download
M build_overrides/build.gni View 1 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 24 (10 generated)
erikchen
mark: Please review.
4 years, 8 months ago (2016-03-30 20:48:38 UTC) #3
Mark Mentovai
LGTM
4 years, 8 months ago (2016-03-30 20:50:35 UTC) #4
erikchen
thakis: Please review.
4 years, 8 months ago (2016-04-04 17:39:45 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847533004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847533004/1
4 years, 8 months ago (2016-04-04 17:40:00 UTC) #8
Nico
Nice! Do the same in gn...looks like that's now in build_overrides/build.gni https://codereview.chromium.org/1847533004/diff/1/build/common.gypi File build/common.gypi (right): ...
4 years, 8 months ago (2016-04-04 18:01:24 UTC) #9
erikchen
dpranke: Please review. thakis: PTAL https://codereview.chromium.org/1847533004/diff/40001/build_overrides/build.gni File build_overrides/build.gni (right): https://codereview.chromium.org/1847533004/diff/40001/build_overrides/build.gni#newcode9 build_overrides/build.gni:9: # requires 10.7. After ...
4 years, 8 months ago (2016-04-04 18:53:18 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847533004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847533004/40001
4 years, 8 months ago (2016-04-04 18:54:00 UTC) #12
Nico
lgtm, thanks
4 years, 8 months ago (2016-04-04 19:00:44 UTC) #13
erikchen
+dpranke, for real this time.
4 years, 8 months ago (2016-04-04 19:38:39 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-04 20:04:27 UTC) #17
Dirk Pranke
lgtm. I don't know if we'll need to keep the build_overrides file around or not.
4 years, 8 months ago (2016-04-04 20:56:32 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847533004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847533004/40001
4 years, 8 months ago (2016-04-04 20:58:42 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-04 21:05:13 UTC) #22
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 21:06:45 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4bdf946cb5e01a3165fbe4e64ca15ff5aaa2ef5f
Cr-Commit-Position: refs/heads/master@{#385003}

Powered by Google App Engine
This is Rietveld 408576698