|
|
Descriptionmac: Bump the deployment target to OS X 10.7.
BUG=592663
Committed: https://crrev.com/4bdf946cb5e01a3165fbe4e64ca15ff5aaa2ef5f
Cr-Commit-Position: refs/heads/master@{#385003}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Comments from thakis. #Patch Set 3 : Comments from thakis. #
Total comments: 1
Messages
Total messages: 24 (10 generated)
Description was changed from ========== mac: Bump the deployment target to OS X 10.7. BUG= ========== to ========== mac: Bump the deployment target to OS X 10.7. BUG=592663 ==========
erikchen@chromium.org changed reviewers: + mark@chromium.org
mark: Please review.
LGTM
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
erikchen@chromium.org changed reviewers: + thakis@chromium.org
thakis: Please review.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847533004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847533004/1
Nice! Do the same in gn...looks like that's now in build_overrides/build.gni https://codereview.chromium.org/1847533004/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/1847533004/diff/1/build/common.gypi#newcode1965 build/common.gypi:1965: 'mac_deployment_target%': '10.7', These can merge again now, right? iOS only cares about "at least 10.7", so no need to have two of these anymore.
dpranke: Please review. thakis: PTAL https://codereview.chromium.org/1847533004/diff/40001/build_overrides/build.gni File build_overrides/build.gni (right): https://codereview.chromium.org/1847533004/diff/40001/build_overrides/build.g... build_overrides/build.gni:9: # requires 10.7. After this CL lands and sticks, we will still need to keep this file because of the 10.11 SDK requirement?
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847533004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847533004/40001
lgtm, thanks
erikchen@chromium.org changed reviewers: + dpranke@chromium.org
+dpranke, for real this time.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm. I don't know if we'll need to keep the build_overrides file around or not.
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org Link to the patchset: https://codereview.chromium.org/1847533004/#ps40001 (title: "Comments from thakis.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847533004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847533004/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== mac: Bump the deployment target to OS X 10.7. BUG=592663 ========== to ========== mac: Bump the deployment target to OS X 10.7. BUG=592663 Committed: https://crrev.com/4bdf946cb5e01a3165fbe4e64ca15ff5aaa2ef5f Cr-Commit-Position: refs/heads/master@{#385003} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4bdf946cb5e01a3165fbe4e64ca15ff5aaa2ef5f Cr-Commit-Position: refs/heads/master@{#385003} |