Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 184753003: Remove more flags not needed by android framework. (Closed)

Created:
6 years, 9 months ago by scroggo
Modified:
6 years, 9 months ago
Reviewers:
djsollen, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove more flags not needed by android framework. Committed: http://code.google.com/p/skia/source/detail?r=13934

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comments; remove duplicates. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M gyp/common_conditions.gypi View 1 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scroggo
6 years, 9 months ago (2014-02-28 17:32:38 UTC) #1
scroggo
On 2014/02/28 17:32:38, scroggo wrote: ping.
6 years, 9 months ago (2014-03-24 21:36:39 UTC) #2
reed1
lgtm w/ request for comment explaining why these are disabled. https://codereview.chromium.org/184753003/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.chromium.org/184753003/diff/1/gyp/common_conditions.gypi#newcode228 ...
6 years, 9 months ago (2014-03-25 14:20:16 UTC) #3
scroggo
https://codereview.chromium.org/184753003/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.chromium.org/184753003/diff/1/gyp/common_conditions.gypi#newcode228 gyp/common_conditions.gypi:228: 'cflags!': [ On 2014/03/25 14:20:16, reed1 wrote: > // ...
6 years, 9 months ago (2014-03-25 14:38:11 UTC) #4
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 9 months ago (2014-03-25 14:57:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/184753003/40001
6 years, 9 months ago (2014-03-25 14:57:42 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 15:14:20 UTC) #7
Message was sent while issue was closed.
Change committed as 13934

Powered by Google App Engine
This is Rietveld 408576698