Fix memory leak from use of SECKEY_ConvertToPublicKey().

Fix memory leak from use of SECKEY_ConvertToPublicKey().

BUG=347965, 245025
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254202

[eroman, 2014-02-28 17:21:00]

I suck.

[Ryan Sleevi, 2014-02-28 17:25:02]

I do for not catching it. Smaller CLs in the future? ;)

LGTM
On Feb 28, 2014 9:21 AM, <eroman@chromium.org> wrote:

> Reviewers: Ryan Sleevi,
>
> Message:
> I suck.
>
> Description:
> Fix memory leak from use of SECKEY_ConvertToPublicKey().
>
> BUG=347965,245025
>
> Please review this at https://codereview.chromium.org/184753002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+2, -2 lines):
>   M content/renderer/webcrypto/platform_crypto_nss.cc
>
>
> Index: content/renderer/webcrypto/platform_crypto_nss.cc
> diff --git a/content/renderer/webcrypto/platform_crypto_nss.cc
> b/content/renderer/webcrypto/platform_crypto_nss.cc
> index 67e2e8bbddefd1e30df62b1f770a810812f71422..
> eca13a8e0c7e35170c293e4cf81a04bf85756c4d 100644
> --- a/content/renderer/webcrypto/platform_crypto_nss.cc
> +++ b/content/renderer/webcrypto/platform_crypto_nss.cc
> @@ -441,8 +441,8 @@ bool CreatePublicKeyAlgorithm(const
> blink::WebCryptoAlgorithm& algorithm,
>  bool CreatePrivateKeyAlgorithm(const blink::WebCryptoAlgorithm&
> algorithm,
>                                 SECKEYPrivateKey* key,
>                                 blink::WebCryptoKeyAlgorithm*
> key_algorithm) {
> -  return CreatePublicKeyAlgorithm(
> -      algorithm, SECKEY_ConvertToPublicKey(key), key_algorithm);
> +  crypto::ScopedSECKEYPublicKey public_key(SECKEY_
> ConvertToPublicKey(key));
> +  return CreatePublicKeyAlgorithm(algorithm, public_key.get(),
> key_algorithm);
>  }
>
>  }  // namespace
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[eroman, 2014-02-28 17:29:00]

I just added the removal of suppression to this list. Sorry for not adding that
in first patchset.

[eroman, 2014-02-28 17:32:50]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-02-28 17:33:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/184753002/20001

[eroman, 2014-02-28 19:09:27]

The CQ bit was unchecked by eroman@chromium.org

[eroman, 2014-02-28 19:34:53]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-02-28 19:35:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/184753002/20001

[commit-bot: I haz the power, 2014-02-28 20:09:12]

Change committed as 254202