Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 1847513002: Revert of Factor out setIndexedDBClientCreateFunction from blink::initialize (Closed)

Created:
4 years, 8 months ago by haraken
Modified:
4 years, 8 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Factor out setIndexedDBClientCreateFunction from blink::initialize (patchset #3 id:40001 of https://codereview.chromium.org/1823953002/ ) Reason for revert: This caused threading race: https://bugs.chromium.org/p/chromium/issues/detail?id=599011#c1 Original issue's description: > Factor out setIndexedDBClientCreateFunction from blink::initialize > > This CL moves setIndexedDBClientCreateFunction to WorkerContentSettingsClient's constructor > and WebLocalFrame's constructor. > > BUG=593269 > > Committed: https://crrev.com/3056d79df9ba4fe776a42455ebb1f495bd582ad2 > Cr-Commit-Position: refs/heads/master@{#382538} TBR=sigbjornf@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=593269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M third_party/WebKit/Source/web/IndexedDBClientImpl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebKit.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WorkerContentSettingsClient.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
haraken
Created Revert of Factor out setIndexedDBClientCreateFunction from blink::initialize
4 years, 8 months ago (2016-03-30 09:34:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847513002/1
4 years, 8 months ago (2016-03-30 09:34:30 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn/builds/10957)
4 years, 8 months ago (2016-03-30 09:36:14 UTC) #4
sof
This revert failed to land; let me fix the underlying race instead.
4 years, 8 months ago (2016-04-07 11:20:17 UTC) #5
haraken
4 years, 8 months ago (2016-04-07 11:20:45 UTC) #6
On 2016/04/07 11:20:17, sof wrote:
> This revert failed to land; let me fix the underlying race instead.

ah, sorry, thanks!

Powered by Google App Engine
This is Rietveld 408576698