WebCrypto: Add framework for AlgorithmIdentifier normalization.

Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp

Index: Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp
diff --git a/Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp b/Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..b417e5a3150774ef5701b393a5e5ad6a6a6a6944
--- /dev/null
+++ b/Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp
@@ -0,0 +1,108 @@
+/*
+ * Copyright (C) 2013 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "public/platform/WebCryptoAlgorithm.h"
+
+#include "public/platform/WebCryptoAlgorithmParams.h"
+#include "wtf/OwnPtr.h"
+#include "wtf/ThreadSafeRefCounted.h"
+#include <string.h>

[abarth-chromium, 2013/07/02 06:46:36]

Should this be "#include <string>" ?  I though the ".h" versions were
deprecated.

I don't see where this header is used.  Can we remove it?

[eroman, 2013/07/02 08:12:27]

Done.

+
+namespace WebKit {
+
+// Use a reference counted to make copying easier.

[abarth-chromium, 2013/07/02 06:46:36]

I'd skip this comment.

[eroman, 2013/07/02 08:12:27]

Done.

+class WebCryptoAlgorithmPrivate : public ThreadSafeRefCounted<WebCryptoAlgorithmPrivate> {
+public:
+    WebCryptoAlgorithmPrivate(WebCryptoAlgorithmId algorithmId, const char* algorithmName, PassOwnPtr<WebCryptoAlgorithmParams> params)
+        : algorithmId(algorithmId)
+        , algorithmName(algorithmName)
+        , params(params)
+    {
+    }
+
+    WebCryptoAlgorithmId algorithmId;

[abarth-chromium, 2013/07/02 06:46:36]

Id -> ID ?  I'm not sure what's most consistent with existing style...

[eroman, 2013/07/02 08:12:27]

I will do some more research on this matter tomorrow. For now I have left it as
"Id".

[eroman, 2013/07/02 18:03:44]

It looks like both styles are equally common in the blink codebase:

Across all directories in WebKit/Source the counts are:
  ID: 2283
  Id: 2450

For just the WebKit API directory however "Id" is 4x more common than "ID":
  ID: 11
  Id: 44

This data doesn't strongly motivate using one style over the other. Given the
slight lead of "Id" (especially in WebKit API) I will use that style.

Testing methodology:

$ cd ROOT_DIR
$ grep -r '[a-z]ID\>' * | egrep '[.](cc|cpp|m|mm|h): ' | wc -l
$ grep -r '[a-z]Id\>' * | egrep '[.](cc|cpp|m|mm|h): ' | wc -l

+    const char* const algorithmName;
+    OwnPtr<WebCryptoAlgorithmParams> params;
+};
+
+WebCryptoAlgorithm::WebCryptoAlgorithm(WebCryptoAlgorithmId algorithmId, const char* algorithmName, PassOwnPtr<WebCryptoAlgorithmParams> params)
+    : m_private(adoptRef(new WebCryptoAlgorithmPrivate(algorithmId, algorithmName, params)))
+{
+}
+
+WebCryptoAlgorithm::~WebCryptoAlgorithm()
+{
+    m_private.reset();
+}
+
+WebCryptoAlgorithm::WebCryptoAlgorithm(const WebCryptoAlgorithm& other)
+{
+    *this = other;
+}
+
+WebCryptoAlgorithm& WebCryptoAlgorithm::operator=(const WebCryptoAlgorithm& other)
+{
+    m_private = other.m_private;
+    return *this;
+}
+
+WebCryptoAlgorithmId WebCryptoAlgorithm::algorithmId() const
+{
+    return m_private->algorithmId;
+}
+
+const char* WebCryptoAlgorithm::algorithmName() const
+{
+    return m_private->algorithmName;
+}
+
+WebCryptoAlgorithmParamsType WebCryptoAlgorithm::paramsType() const
+{
+    if (!m_private->params)
+        return NoParams;
+    return m_private->params->type();
+}
+
+WebCryptoAesCbcParams* WebCryptoAlgorithm::getAesCbcParams() const
+{
+    if (paramsType() == AesCbcParams)
+        return static_cast<WebCryptoAesCbcParams*>(m_private->params.get());
+    return 0;
+}
+
+WebCryptoAesKeyGenParams* WebCryptoAlgorithm::getAesKeyGenParams() const
+{
+    if (paramsType() == AesKeyGenParams)
+        return static_cast<WebCryptoAesKeyGenParams*>(m_private->params.get());
+    return 0;
+}
+
+} // namespace WebKit