Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1847483002: Cleanup leadingWhitespacePosition() (Closed)

Created:
4 years, 8 months ago by yosin_UTC9
Modified:
4 years, 8 months ago
Reviewers:
tkent, yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup leadingWhitespacePosition() This patch makes |leadingWhitespacePosition()| in early return style with expanding |inSameContainingBlockFlowElement()| into it, which is used only in here. This patch is a preparation of http://crrev.com/1842753004. BUG=598665 TEST=n/a; no behavior changes Committed: https://crrev.com/07acbd0212cb0ae85e4828410648c04e94f3e3e2 Cr-Commit-Position: refs/heads/master@{#384229}

Patch Set 1 #

Patch Set 2 : 2016-03-31T11:43:17 #

Patch Set 3 : 2016-03-31T14:52:38 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M third_party/WebKit/Source/core/editing/EditingUtilities.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 2 2 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
yosin_UTC9
PTAL Bot failures are caused by Goma instead of this patch.
4 years, 8 months ago (2016-03-31 06:21:01 UTC) #4
tkent
lgtm
4 years, 8 months ago (2016-03-31 06:59:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847483002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847483002/40001
4 years, 8 months ago (2016-03-31 07:09:02 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-31 09:25:57 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 09:27:29 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/07acbd0212cb0ae85e4828410648c04e94f3e3e2
Cr-Commit-Position: refs/heads/master@{#384229}

Powered by Google App Engine
This is Rietveld 408576698