Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1847433002: Add warning when running gclient under MSYS shell. (Closed)

Created:
4 years, 8 months ago by iannucci
Modified:
4 years, 8 months ago
Reviewers:
dnj, Peter Kasting
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix quotes #

Patch Set 3 : Make comment better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M update_depot_tools View 1 2 2 chunks +17 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
iannucci
4 years, 8 months ago (2016-03-30 02:29:01 UTC) #1
dnj
lgtm
4 years, 8 months ago (2016-03-30 02:30:26 UTC) #2
iannucci
pkasting@: would this warning have been sufficiently informative?
4 years, 8 months ago (2016-03-30 02:32:21 UTC) #3
Peter Kasting
Yeah, this seems fine.
4 years, 8 months ago (2016-03-30 02:38:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847433002/40001
4 years, 8 months ago (2016-03-30 02:42:59 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 02:45:17 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299559

Powered by Google App Engine
This is Rietveld 408576698