skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc - Issue 184743002: don't create SkDevice directly, use SkBitmap or (better) SkCanvas::NewRaster factory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc

Issue 184743002: don't create SkDevice directly, use SkBitmap or (better) SkCanvas::NewRaster factory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert changes to media unittests til we understand valgrind errors Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc

diff --git a/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc b/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc

index 1cb4d7f6ebd9f69e5c319947aba7d1b301eb57d5..2d37a2d4edaf63b12e60998bccaf83048a482926 100644

--- a/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc

+++ b/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc

@@ -4,7 +4,6 @@

#include "base/file_util.h"

#include "base/logging.h"

-#include "third_party/skia/include/core/SkBitmapDevice.h"

#include "third_party/skia/include/core/SkCanvas.h"

#include "third_party/skia/include/core/SkFlattenableSerialization.h"

#include "third_party/skia/include/core/SkImageFilter.h"

@@ -74,10 +73,8 @@ int main(int argc, char** argv) {

int ret = 0;

SkBitmap bitmap;

- bitmap.setConfig(SkBitmap::kARGB_8888_Config, BitmapSize, BitmapSize);

- bitmap.allocPixels();

- SkBitmapDevice device(bitmap);

- SkCanvas canvas(&device);

+ bitmap.allocN32Pixels(BitmapSize, BitmapSize);

+ SkCanvas canvas(bitmap);

canvas.clear(0x00000000);

for (int i = 1; i < argc; i++)

« no previous file with comments | « skia/ext/benchmarking_canvas.cc ('k') | no next file » | no next file with comments »