android_webview/browser/browser_view_renderer.cc - Issue 184743002: don't create SkDevice directly, use SkBitmap or (better) SkCanvas::NewRaster factory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/browser_view_renderer.cc

Issue 184743002: don't create SkDevice directly, use SkBitmap or (better) SkCanvas::NewRaster factory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | android_webview/native/java_browser_view_renderer_helper.cc » ('j') | content/browser/renderer_host/render_widget_host_view_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/browser_view_renderer.cc

diff --git a/android_webview/browser/browser_view_renderer.cc b/android_webview/browser/browser_view_renderer.cc

index 1750b44770156aad556aeb359f0f718373cea662..1d7bf5f8fbbf265bae215f09c816b77e37f07a33 100644

--- a/android_webview/browser/browser_view_renderer.cc

+++ b/android_webview/browser/browser_view_renderer.cc

@@ -17,7 +17,6 @@

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/web_contents.h"

#include "third_party/skia/include/core/SkBitmap.h"

-#include "third_party/skia/include/core/SkBitmapDevice.h"

#include "third_party/skia/include/core/SkCanvas.h"

#include "third_party/skia/include/core/SkPicture.h"

#include "ui/gfx/vector2d_conversions.h"

@@ -477,8 +476,10 @@ void BrowserViewRenderer::FallbackTickFired() {

void BrowserViewRenderer::ForceFakeCompositeSW() {

DCHECK(has_compositor_);

- SkBitmapDevice device(SkBitmap::kARGB_8888_Config, 1, 1);

- SkCanvas canvas(&device);

+ SkBitmap bitmap;

+ bitmap.allocN32Pixels(1, 1);

+ bitmap.eraseColor(0);

+ SkCanvas canvas(bitmap);

CompositeSW(&canvas);

}