content/browser/compositor/software_output_device_ozone.cc - Issue 184743002: don't create SkDevice directly, use SkBitmap or (better) SkCanvas::NewRaster factory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/compositor/software_output_device_ozone.cc

Issue 184743002: don't create SkDevice directly, use SkBitmap or (better) SkCanvas::NewRaster factory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert changes to media unittests til we understand valgrind errors Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/browser/compositor/software_output_device_ozone.h"	5 #include "content/browser/compositor/software_output_device_ozone.h"

6 #include "third_party/skia/include/core/SkBitmapDevice.h"

7 #include "third_party/skia/include/core/SkDevice.h"	6 #include "third_party/skia/include/core/SkDevice.h"

8 #include "ui/compositor/compositor.h"	7 #include "ui/compositor/compositor.h"

9 #include "ui/gfx/ozone/surface_factory_ozone.h"	8 #include "ui/gfx/ozone/surface_factory_ozone.h"

10 #include "ui/gfx/skia_util.h"	9 #include "ui/gfx/skia_util.h"

11 #include "ui/gfx/vsync_provider.h"	10 #include "ui/gfx/vsync_provider.h"

12	11

13 namespace content {	12 namespace content {

14	13

15 SoftwareOutputDeviceOzone::SoftwareOutputDeviceOzone(ui::Compositor* compositor)	14 SoftwareOutputDeviceOzone::SoftwareOutputDeviceOzone(ui::Compositor* compositor)

16 : compositor_(compositor), realized_widget_(gfx::kNullAcceleratedWidget) {	15 : compositor_(compositor), realized_widget_(gfx::kNullAcceleratedWidget) {

(...skipping 47 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
64	63

65 if (damage_rect_.IsEmpty())	64 if (damage_rect_.IsEmpty())

66 return;	65 return;

67	66

68 bool scheduled = gfx::SurfaceFactoryOzone::GetInstance()->SchedulePageFlip(	67 bool scheduled = gfx::SurfaceFactoryOzone::GetInstance()->SchedulePageFlip(

69 compositor_->widget());	68 compositor_->widget());

70 DCHECK(scheduled) << "Failed to schedule pageflip";	69 DCHECK(scheduled) << "Failed to schedule pageflip";

71 }	70 }

72	71

73 } // namespace content	72 } // namespace content

OLD	NEW