src/IceCfg.cpp - Issue 1847423003: Replace constant conditional branches by unconditional branches

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceCfg.cpp

Issue 1847423003: Replace constant conditional branches by unconditional branches (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceCfg.cpp

diff --git a/src/IceCfg.cpp b/src/IceCfg.cpp

index 2d16734eab18b9cea1761e5705670314bff69451..79dfd767540433f04897a62e221789517c1c55c4 100644

--- a/src/IceCfg.cpp

+++ b/src/IceCfg.cpp

@@ -283,7 +283,7 @@ void Cfg::computeInOutEdges() {

TimerMarker T(TimerStack::TT_phiValidation, this);

for (CfgNode *Node : Nodes)

- Node->validatePhis();

+ Node->enforcePhiConsistency();

}

void Cfg::renumberInstructions() {

« no previous file with comments | « no previous file | src/IceCfgNode.h » ('j') | src/IceCfgNode.cpp » ('J')