Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1427)

Unified Diff: test/mjsunit/es6/regexp-flags.js

Issue 1847423002: Version 5.1.244.1 (cherry-pick) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@5.1.244
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/flag-definitions.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/es6/regexp-flags.js
diff --git a/test/mjsunit/es6/regexp-flags.js b/test/mjsunit/es6/regexp-flags.js
index ad40c43b69baf4fdfa82eb5c24df012fe177d448..98d9dec65bc051739c2e260205ca0e8889e55b6a 100644
--- a/test/mjsunit/es6/regexp-flags.js
+++ b/test/mjsunit/es6/regexp-flags.js
@@ -44,11 +44,9 @@ assertEquals(2, get_count);
// Overridden flag getters affects the flags getter.
assertEquals("gi", r3.flags);
assertEquals(4, get_count);
-// Overridden flag getters affect string.replace
-// TODO(adamk): Add more tests here once we've switched
-// to use [[OriginalFlags]] in more cases.
+// Overridden flag getters do not affect the internal flags.
assertEquals(expected, string.replace(r3, "X"));
-assertEquals(5, get_count);
+assertEquals(4, get_count);
function testName(name) {
« no previous file with comments | « src/flag-definitions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698