Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1847413002: Fixed rotate left on windows. (Closed)

Created:
4 years, 8 months ago by ahaas
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fixed rotate left on windows. R=titzer@chromium.org, bmeurer@chromium.org Committed: https://crrev.com/3ffee875eff9b0f333e86998a55ce7b5ff3f110f Cr-Commit-Position: refs/heads/master@{#35195}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/base/win32-headers.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
ahaas
4 years, 8 months ago (2016-04-01 09:26:20 UTC) #1
titzer
lgtm
4 years, 8 months ago (2016-04-01 09:32:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847413002/1
4 years, 8 months ago (2016-04-01 09:32:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 09:50:26 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3ffee875eff9b0f333e86998a55ce7b5ff3f110f Cr-Commit-Position: refs/heads/master@{#35195}
4 years, 8 months ago (2016-04-01 09:52:21 UTC) #7
Benedikt Meurer
4 years, 8 months ago (2016-04-01 09:52:41 UTC) #8
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698