Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Side by Side Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 1847373002: [debugger] fix step-next for tail calls. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix reloc info Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 2618 matching lines...) Expand 10 before | Expand all | Expand 10 after
2629 void FullCodeGenerator::EmitCall(Call* expr, ConvertReceiverMode mode) { 2629 void FullCodeGenerator::EmitCall(Call* expr, ConvertReceiverMode mode) {
2630 // Load the arguments. 2630 // Load the arguments.
2631 ZoneList<Expression*>* args = expr->arguments(); 2631 ZoneList<Expression*>* args = expr->arguments();
2632 int arg_count = args->length(); 2632 int arg_count = args->length();
2633 for (int i = 0; i < arg_count; i++) { 2633 for (int i = 0; i < arg_count; i++) {
2634 VisitForStackValue(args->at(i)); 2634 VisitForStackValue(args->at(i));
2635 } 2635 }
2636 2636
2637 PrepareForBailoutForId(expr->CallId(), NO_REGISTERS); 2637 PrepareForBailoutForId(expr->CallId(), NO_REGISTERS);
2638 // Record source position of the IC call. 2638 // Record source position of the IC call.
2639 SetCallPosition(expr); 2639 SetCallPosition(expr, expr->tail_call_mode());
2640 if (expr->tail_call_mode() == TailCallMode::kAllow) { 2640 if (expr->tail_call_mode() == TailCallMode::kAllow) {
2641 if (FLAG_trace) { 2641 if (FLAG_trace) {
2642 __ CallRuntime(Runtime::kTraceTailCall); 2642 __ CallRuntime(Runtime::kTraceTailCall);
2643 } 2643 }
2644 // Update profiling counters before the tail call since we will 2644 // Update profiling counters before the tail call since we will
2645 // not return to this function. 2645 // not return to this function.
2646 EmitProfilingCounterHandlingForReturnSequence(true); 2646 EmitProfilingCounterHandlingForReturnSequence(true);
2647 } 2647 }
2648 Handle<Code> ic = 2648 Handle<Code> ic =
2649 CodeFactory::CallIC(isolate(), arg_count, mode, expr->tail_call_mode()) 2649 CodeFactory::CallIC(isolate(), arg_count, mode, expr->tail_call_mode())
(...skipping 1462 matching lines...) Expand 10 before | Expand all | Expand 10 after
4112 reinterpret_cast<uint64_t>( 4112 reinterpret_cast<uint64_t>(
4113 isolate->builtins()->OnStackReplacement()->entry())); 4113 isolate->builtins()->OnStackReplacement()->entry()));
4114 return ON_STACK_REPLACEMENT; 4114 return ON_STACK_REPLACEMENT;
4115 } 4115 }
4116 4116
4117 4117
4118 } // namespace internal 4118 } // namespace internal
4119 } // namespace v8 4119 } // namespace v8
4120 4120
4121 #endif // V8_TARGET_ARCH_MIPS64 4121 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698