Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 1847373002: [debugger] fix step-next for tail calls. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix reloc info Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 2617 matching lines...) Expand 10 before | Expand all | Expand 10 after
2628 void FullCodeGenerator::EmitCall(Call* expr, ConvertReceiverMode mode) { 2628 void FullCodeGenerator::EmitCall(Call* expr, ConvertReceiverMode mode) {
2629 // Load the arguments. 2629 // Load the arguments.
2630 ZoneList<Expression*>* args = expr->arguments(); 2630 ZoneList<Expression*>* args = expr->arguments();
2631 int arg_count = args->length(); 2631 int arg_count = args->length();
2632 for (int i = 0; i < arg_count; i++) { 2632 for (int i = 0; i < arg_count; i++) {
2633 VisitForStackValue(args->at(i)); 2633 VisitForStackValue(args->at(i));
2634 } 2634 }
2635 2635
2636 PrepareForBailoutForId(expr->CallId(), NO_REGISTERS); 2636 PrepareForBailoutForId(expr->CallId(), NO_REGISTERS);
2637 // Record source position of the IC call. 2637 // Record source position of the IC call.
2638 SetCallPosition(expr); 2638 SetCallPosition(expr, expr->tail_call_mode());
2639 if (expr->tail_call_mode() == TailCallMode::kAllow) { 2639 if (expr->tail_call_mode() == TailCallMode::kAllow) {
2640 if (FLAG_trace) { 2640 if (FLAG_trace) {
2641 __ CallRuntime(Runtime::kTraceTailCall); 2641 __ CallRuntime(Runtime::kTraceTailCall);
2642 } 2642 }
2643 // Update profiling counters before the tail call since we will 2643 // Update profiling counters before the tail call since we will
2644 // not return to this function. 2644 // not return to this function.
2645 EmitProfilingCounterHandlingForReturnSequence(true); 2645 EmitProfilingCounterHandlingForReturnSequence(true);
2646 } 2646 }
2647 Handle<Code> ic = 2647 Handle<Code> ic =
2648 CodeFactory::CallIC(isolate(), arg_count, mode, expr->tail_call_mode()) 2648 CodeFactory::CallIC(isolate(), arg_count, mode, expr->tail_call_mode())
(...skipping 1453 matching lines...) Expand 10 before | Expand all | Expand 10 after
4102 reinterpret_cast<uint32_t>( 4102 reinterpret_cast<uint32_t>(
4103 isolate->builtins()->OnStackReplacement()->entry())); 4103 isolate->builtins()->OnStackReplacement()->entry()));
4104 return ON_STACK_REPLACEMENT; 4104 return ON_STACK_REPLACEMENT;
4105 } 4105 }
4106 4106
4107 4107
4108 } // namespace internal 4108 } // namespace internal
4109 } // namespace v8 4109 } // namespace v8
4110 4110
4111 #endif // V8_TARGET_ARCH_MIPS 4111 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698