Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1847373002: [debugger] fix step-next for tail calls. (Closed)

Created:
4 years, 8 months ago by Yang
Modified:
4 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] fix step-next for tail calls. R=ishell@chromium.org BUG=v8:4698 LOG=N Committed: https://crrev.com/3d4f85ab9f38340082519dea318bfe2ad967a5a5 Cr-Commit-Position: refs/heads/master@{#35230}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix reloc info #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -23 lines) Patch
M src/arm64/assembler-arm64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.h View 3 chunks +5 lines, -1 line 0 comments Download
M src/assembler.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/debug/debug.h View 1 4 chunks +8 lines, -2 lines 0 comments Download
M src/debug/debug.cc View 1 6 chunks +21 lines, -4 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/full-codegen.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/assembler-mips.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/assembler-mips64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Yang
4 years, 8 months ago (2016-04-01 08:34:48 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847373002/1
4 years, 8 months ago (2016-04-01 09:51:33 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/16019) v8_linux64_avx2_rel on ...
4 years, 8 months ago (2016-04-01 10:06:11 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847373002/20001
4 years, 8 months ago (2016-04-04 07:25:10 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/17714)
4 years, 8 months ago (2016-04-04 08:00:25 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847373002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847373002/40001
4 years, 8 months ago (2016-04-04 08:20:41 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-04 08:45:28 UTC) #14
Igor Sheludko
lgtm
4 years, 8 months ago (2016-04-04 09:35:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847373002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847373002/40001
4 years, 8 months ago (2016-04-04 09:36:44 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-04 09:38:47 UTC) #19
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 09:40:41 UTC) #21
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3d4f85ab9f38340082519dea318bfe2ad967a5a5
Cr-Commit-Position: refs/heads/master@{#35230}

Powered by Google App Engine
This is Rietveld 408576698