Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 1847343003: Correct conversion from flowthread to visual coordinate space when there's border/padding. (Closed)

Created:
4 years, 8 months ago by mstensho (USE GERRIT)
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct conversion from flowthread to visual coordinate space when there's border/padding. If an inner multicol container has border or padding, just using the outer block offset stored in the inner flow thread won't be good enough. We need to find the actual first fragmentainer group in the first column set. Or, put simply: let's do what the comment in the code actually says! Committed: https://crrev.com/66a452d99ee2a39e60d25a5e119ebb234546b0aa Cr-Commit-Position: refs/heads/master@{#384737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/multicol/nested-with-padding.html View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/nested-with-padding-expected.html View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
mstensho (USE GERRIT)
@leviw, aka the man who can nest 5 multicols inside each other: Here's a friendly ...
4 years, 8 months ago (2016-04-01 21:36:20 UTC) #1
mstensho (USE GERRIT)
@leviw, aka the man who can nest 5 multicols inside each other: Here's a friendly ...
4 years, 8 months ago (2016-04-01 21:36:50 UTC) #3
leviw_travelin_and_unemployed
lgtm This patch is so easy to follow I'm crying!
4 years, 8 months ago (2016-04-01 22:27:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847343003/1
4 years, 8 months ago (2016-04-01 22:27:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-02 00:00:02 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 00:01:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66a452d99ee2a39e60d25a5e119ebb234546b0aa
Cr-Commit-Position: refs/heads/master@{#384737}

Powered by Google App Engine
This is Rietveld 408576698