Allow input.ime.activate() to be called from a non-user-action for the first time.

Allow input.ime.activate() to be called from a non-user-action for the first time.

Currently, input.ime.activate() is only allowed to be called from a user action. This will bring a lot of efforts to activate the engine if user shut down and restart chrome. We want to make an exception that, if the user allows to activate the extension by default, then the extension could successfully call activate() when loaded, and only for once. That means, it still needs from user action if calling input.ime.activate() many times.

BUG=517773
TEST=None

Committed: https://crrev.com/035cd6af08529a2084e251a6115e63a13f97ff3d
Cr-Commit-Position: refs/heads/master@{#384750}

[Azure Wei, 2016-04-01 04:40:10]

Description was changed from

==========
Allow input.ime.activate() to be called from a non-user-action for the first
time.

BUG=517773
TEST=None
==========

to

==========
Allow input.ime.activate() to be called from a non-user-action for the first
time.

Currently, input.ime.activate() is only allowed to be called from a user action.
This will bring a lot of efforts to activate the engine if user shut down and
restart chrome. We want to make an exception that, if the user allows to
activate the extension by default, then the extension could successfully call
activate() when loaded, and only for once. That means, it still needs from user
action if calling input.ime.activate() many times.

BUG=517773
TEST=None
==========

[Azure Wei, 2016-04-01 04:40:10]

azurewei@chromium.org changed reviewers:
+ shuchen@chromium.org

[Azure Wei, 2016-04-01 04:51:04]

Hello Shu, please review this cl. Thank you!

[Shu Chen, 2016-04-01 08:10:52]

https://codereview.chromium.org/1847343002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc
(right):

https://codereview.chromium.org/1847343002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc:206: bool
allowed_to_activate = false;
s/allowed_to_activate/warning_bubble_never_show/g

https://codereview.chromium.org/1847343002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc:209: if
(prefs->ReadPrefAsBoolean(extension_id(), kPrefImeActivatedCalledBefore,
I think this block should also be after the disable_bubble_for_testing_ check?

[Azure Wei, 2016-04-01 13:34:05]

https://codereview.chromium.org/1847343002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc
(right):

https://codereview.chromium.org/1847343002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc:206: bool
allowed_to_activate = false;
On 2016/04/01 08:10:52, Shu Chen wrote:
> s/allowed_to_activate/warning_bubble_never_show/g

Done.

https://codereview.chromium.org/1847343002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc:209: if
(prefs->ReadPrefAsBoolean(extension_id(), kPrefImeActivatedCalledBefore,
On 2016/04/01 08:10:52, Shu Chen wrote:
> I think this block should also be after the disable_bubble_for_testing_ check?

If put this after disable_bubble_for_testing_, it won't change anything as it
still needs to check user_gesture() every time.
p.s., tests use ScopedUserGestureForTests to make user_gesture() return true.

[Shu Chen, 2016-04-01 14:52:44]

lgtm

[Azure Wei, 2016-04-01 22:15:49]

The CQ bit was checked by azurewei@chromium.org

[commit-bot: I haz the power, 2016-04-01 22:16:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847343002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847343002/20001

[commit-bot: I haz the power, 2016-04-02 00:15:30]

Description was changed from

==========
Allow input.ime.activate() to be called from a non-user-action for the first
time.

Currently, input.ime.activate() is only allowed to be called from a user action.
This will bring a lot of efforts to activate the engine if user shut down and
restart chrome. We want to make an exception that, if the user allows to
activate the extension by default, then the extension could successfully call
activate() when loaded, and only for once. That means, it still needs from user
action if calling input.ime.activate() many times.

BUG=517773
TEST=None
==========

to

==========
Allow input.ime.activate() to be called from a non-user-action for the first
time.

Currently, input.ime.activate() is only allowed to be called from a user action.
This will bring a lot of efforts to activate the engine if user shut down and
restart chrome. We want to make an exception that, if the user allows to
activate the extension by default, then the extension could successfully call
activate() when loaded, and only for once. That means, it still needs from user
action if calling input.ime.activate() many times.

BUG=517773
TEST=None
==========

[commit-bot: I haz the power, 2016-04-02 00:15:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-02 00:16:41]

Description was changed from

==========
Allow input.ime.activate() to be called from a non-user-action for the first
time.

Currently, input.ime.activate() is only allowed to be called from a user action.
This will bring a lot of efforts to activate the engine if user shut down and
restart chrome. We want to make an exception that, if the user allows to
activate the extension by default, then the extension could successfully call
activate() when loaded, and only for once. That means, it still needs from user
action if calling input.ime.activate() many times.

BUG=517773
TEST=None
==========

to

==========
Allow input.ime.activate() to be called from a non-user-action for the first
time.

Currently, input.ime.activate() is only allowed to be called from a user action.
This will bring a lot of efforts to activate the engine if user shut down and
restart chrome. We want to make an exception that, if the user allows to
activate the extension by default, then the extension could successfully call
activate() when loaded, and only for once. That means, it still needs from user
action if calling input.ime.activate() many times.

BUG=517773
TEST=None

Committed: https://crrev.com/035cd6af08529a2084e251a6115e63a13f97ff3d
Cr-Commit-Position: refs/heads/master@{#384750}
==========

[commit-bot: I haz the power, 2016-04-02 00:16:42]

Patchset 2 (id:??) landed as
https://crrev.com/035cd6af08529a2084e251a6115e63a13f97ff3d
Cr-Commit-Position: refs/heads/master@{#384750}