Remove _FXBSTR* and calls to FX_BSTRC.

core/fpdfapi/fpdf_page/fpdf_page_parser.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_page/pageint.h"
 
 #include <vector>
 
@@ skipping 23 matching lines @@
 namespace {
 
 const char kPathOperatorSubpath = 'm';
 const char kPathOperatorLine = 'l';
 const char kPathOperatorCubicBezier1 = 'c';
 const char kPathOperatorCubicBezier2 = 'v';
 const char kPathOperatorCubicBezier3 = 'y';
 const char kPathOperatorClosePath = 'h';
 const char kPathOperatorRectangle[] = "re";
 
-struct _FX_BSTR {
-  const FX_CHAR* m_Ptr;
-  int m_Size;
-};
-#define _FX_BSTRC(str) \
-  { str, sizeof(str) - 1 }
-
-struct PDF_AbbrPairs {
-  _FX_BSTR full_name;
-  _FX_BSTR abbr;
+struct PDF_AbbrPair {
+  const FX_CHAR* full_name;
+  const FX_CHAR* abbr;
 };
 
-const PDF_AbbrPairs PDF_InlineKeyAbbr[] = {
-    {_FX_BSTRC("BitsPerComponent"), _FX_BSTRC("BPC")},
-    {_FX_BSTRC("ColorSpace"), _FX_BSTRC("CS")},
-    {_FX_BSTRC("Decode"), _FX_BSTRC("D")},
-    {_FX_BSTRC("DecodeParms"), _FX_BSTRC("DP")},
-    {_FX_BSTRC("Filter"), _FX_BSTRC("F")},
-    {_FX_BSTRC("Height"), _FX_BSTRC("H")},
-    {_FX_BSTRC("ImageMask"), _FX_BSTRC("IM")},
-    {_FX_BSTRC("Interpolate"), _FX_BSTRC("I")},
-    {_FX_BSTRC("Width"), _FX_BSTRC("W")},
+const PDF_AbbrPair PDF_InlineKeyAbbr[] = {
+    {"BitsPerComponent", "BPC"}, {"ColorSpace", "CS"}, {"Decode", "D"},
+    {"DecodeParms", "DP"},       {"Filter", "F"},      {"Height", "H"},
+    {"ImageMask", "IM"},         {"Interpolate", "I"}, {"Width", "W"},
 };
 
-const PDF_AbbrPairs PDF_InlineValueAbbr[] = {
-    {_FX_BSTRC("DeviceGray"), _FX_BSTRC("G")},
-    {_FX_BSTRC("DeviceRGB"), _FX_BSTRC("RGB")},
-    {_FX_BSTRC("DeviceCMYK"), _FX_BSTRC("CMYK")},
-    {_FX_BSTRC("Indexed"), _FX_BSTRC("I")},
-    {_FX_BSTRC("ASCIIHexDecode"), _FX_BSTRC("AHx")},
-    {_FX_BSTRC("ASCII85Decode"), _FX_BSTRC("A85")},
-    {_FX_BSTRC("LZWDecode"), _FX_BSTRC("LZW")},
-    {_FX_BSTRC("FlateDecode"), _FX_BSTRC("Fl")},
-    {_FX_BSTRC("RunLengthDecode"), _FX_BSTRC("RL")},
-    {_FX_BSTRC("CCITTFaxDecode"), _FX_BSTRC("CCF")},
-    {_FX_BSTRC("DCTDecode"), _FX_BSTRC("DCT")},
+const PDF_AbbrPair PDF_InlineValueAbbr[] = {
+    {"DeviceGray", "G"},       {"DeviceRGB", "RGB"},
+    {"DeviceCMYK", "CMYK"},    {"Indexed", "I"},
+    {"ASCIIHexDecode", "AHx"}, {"ASCII85Decode", "A85"},
+    {"LZWDecode", "LZW"},      {"FlateDecode", "Fl"},
+    {"RunLengthDecode", "RL"}, {"CCITTFaxDecode", "CCF"},
+    {"DCTDecode", "DCT"},
 };
 
 struct AbbrReplacementOp {
   bool is_replace_key;
   CFX_ByteString key;
   CFX_ByteStringC replacement;
 };
 
 class CPDF_StreamParserAutoClearer {
  public:
   CPDF_StreamParserAutoClearer(CPDF_StreamParser** scoped_variable,
                                CPDF_StreamParser* new_parser)
       : scoped_variable_(scoped_variable) {
     *scoped_variable_ = new_parser;
   }
   ~CPDF_StreamParserAutoClearer() { *scoped_variable_ = NULL; }
 
  private:
   CPDF_StreamParser** scoped_variable_;
 };
 
-CFX_ByteStringC PDF_FindFullName(const PDF_AbbrPairs* table,
+CFX_ByteStringC PDF_FindFullName(const PDF_AbbrPair* table,

[dsinclair, 2016/04/02 00:13:33]

What's your preference for testing something like this? Move it out of the
anonymous namespace, make a PDF_FindFullNameForTesting outside that calls into
this one?

[Tom Sepez, 2016/04/02 18:11:54]

Dunno. May not require a unit test, even, if we hit this somewhere in real pdfs
... 

auto it = std::find_if(table, table + count, [abbr](const PDF_AbbrPair& pair) {
  return pair.abbr == abbr;
});
return it != table + count ? CFX_ByteString(it->full_name) : CFX_ByteString();


or some such ...

[dsinclair, 2016/04/04 15:21:14]

Done.  Add ForTesting wrappers and some simple unittests.

                                  size_t count,
                                  const CFX_ByteStringC& abbr) {
   for (size_t i = 0; i < count; ++i) {
-    if (abbr.GetLength() != table[i].abbr.m_Size)
+    if (abbr.GetLength() < 0 || table[i].abbr[abbr.GetLength() + 1] != '\0')
       continue;
-    if (memcmp(abbr.GetPtr(), table[i].abbr.m_Ptr, abbr.GetLength()))
+    if (memcmp(abbr.GetPtr(), table[i].abbr, abbr.GetLength()))
       continue;
-    return CFX_ByteStringC(table[i].full_name.m_Ptr, table[i].full_name.m_Size);
+    return CFX_ByteStringC(table[i].full_name);
   }
   return CFX_ByteStringC();
 }
 
 }  // namespace
 
 bool IsPathOperator(const uint8_t* buf, size_t len) {
   if (len == 1) {
     uint8_t op = buf[0];
     if (op == kPathOperatorSubpath || op == kPathOperatorLine ||
@@ skipping 1701 matching lines @@
         } else {
           PDF_ReplaceAbbr(pElement);
         }
       }
       break;
     }
     default:
       break;
   }
 }