Use HashMap::add in SVGTextLayoutAttributesBuilder

Use HashMap::add in SVGTextLayoutAttributesBuilder

Removes some redundancies and eliminates double-hashing.
Do the update of default values last. (Avoids assert in AddResult
destructor.)

Committed: https://crrev.com/0f6c84977fee3a56a328e9baa1134b668a316569
Cr-Commit-Position: refs/heads/master@{#384599}

[fs, 2016-04-01 12:53:08]

Description was changed from

==========
Use HashMap::add in SVGTextLayoutAttributesBuilder

Removes some redundancies.
==========

to

==========
Use HashMap::add in SVGTextLayoutAttributesBuilder

Removes some redundancies and eliminates double-hashing.
==========

[fs, 2016-04-01 12:53:08]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, pdr@chromium.org, schenney@chromium.org

[f(malita), 2016-04-01 13:23:36]

Nice, LGTM.

[f(malita), 2016-04-01 13:26:59]

On 2016/04/01 13:23:36, f(malita) wrote:
> Nice, LGTM.

...and I just published your CL, sorry :)

[fs, 2016-04-01 14:27:28]

On 2016/04/01 at 13:26:59, fmalita wrote:
> On 2016/04/01 13:23:36, f(malita) wrote:
> > Nice, LGTM.
> 
> ...and I just published your CL, sorry :)

No worries. Looks like I need to scope/rearrange a bit to avoid triggering the
modification assert in the AddResult destructor though...

[fs, 2016-04-01 14:51:52]

Description was changed from

==========
Use HashMap::add in SVGTextLayoutAttributesBuilder

Removes some redundancies and eliminates double-hashing.
==========

to

==========
Use HashMap::add in SVGTextLayoutAttributesBuilder

Removes some redundancies and eliminates double-hashing.
Do the update of default values last. (Avoids assert in AddResult
destructor.)
==========

[fs, 2016-04-01 15:43:47]

On 2016/04/01 at 13:23:36, fmalita wrote:
> Nice, LGTM.

Moved the setup of the default position (0, 0) - it may warrant another look.
(The order shouldn't matter though.)

[f(malita), 2016-04-01 16:11:22]

On 2016/04/01 15:43:47, fs wrote:
> On 2016/04/01 at 13:23:36, fmalita wrote:
> > Nice, LGTM.
> 
> Moved the setup of the default position (0, 0) - it may warrant another look.
> (The order shouldn't matter though.)

Still LGTM.

[fs, 2016-04-01 16:12:22]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-04-01 16:12:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847333003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847333003/20001

[commit-bot: I haz the power, 2016-04-01 16:18:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-01 16:20:09]

Description was changed from

==========
Use HashMap::add in SVGTextLayoutAttributesBuilder

Removes some redundancies and eliminates double-hashing.
Do the update of default values last. (Avoids assert in AddResult
destructor.)
==========

to

==========
Use HashMap::add in SVGTextLayoutAttributesBuilder

Removes some redundancies and eliminates double-hashing.
Do the update of default values last. (Avoids assert in AddResult
destructor.)

Committed: https://crrev.com/0f6c84977fee3a56a328e9baa1134b668a316569
Cr-Commit-Position: refs/heads/master@{#384599}
==========

[commit-bot: I haz the power, 2016-04-01 16:20:10]

Patchset 2 (id:??) landed as
https://crrev.com/0f6c84977fee3a56a328e9baa1134b668a316569
Cr-Commit-Position: refs/heads/master@{#384599}