MockTransportChannel::GetRemoteSSLCertificate: Prepare for base class change

remoting/protocol/channel_socket_adapter_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/channel_socket_adapter.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/memory/ref_counted.h"
@@ skipping 37 matching lines @@
   MOCK_METHOD1(GetStats, bool(cricket::ConnectionInfos* infos));
   MOCK_CONST_METHOD0(IsDtlsActive, bool());
   MOCK_CONST_METHOD1(GetSslRole, bool(rtc::SSLRole* role));
   MOCK_METHOD1(SetSrtpCiphers, bool(const std::vector<std::string>& ciphers));
   MOCK_METHOD1(GetSrtpCipher, bool(std::string* cipher));
   MOCK_METHOD1(GetSslCipher, bool(std::string* cipher));
   MOCK_CONST_METHOD0(GetLocalCertificate,
                      rtc::scoped_refptr<rtc::RTCCertificate>());
   MOCK_CONST_METHOD1(GetRemoteSSLCertificate,
                      bool(rtc::SSLCertificate** cert));
+
+  // This can't be a real mock method because gmock doesn't support move-only
+  // return values.
+  virtual rtc::scoped_ptr<rtc::SSLCertificate> GetRemoteSSLCertificate() const {

[Sergey Ulanov, 2016/04/05 18:05:23]

I think this should be marked as override instead of virtual, and it won't
compile otherwise.

[kwiberg-chromium, 2016/04/06 08:14:51]

This code must compile both before and after the parent class has a method to
override, and "override" causes a compilation error in the former case, whereas
"virtual" (as you say) causes a compilation error in the latter case.

However, the cause of the error in the latter case isn't something built-in, but
a Chromium-specific warning. And that warning appears to be written specifically
to not apply to classes that use the gmock MOCK_* macros (for a good reason:
those macros predate C++11, and internally use virtual instead of override).

Relying on this is of course horribly ugly. But the second CL---to be landed
after the WebRTC change---replaces "virtual" with "override".

+    EXPECT_TRUE(false);  // Never called.
+    return nullptr;
+  }
+
   MOCK_METHOD6(ExportKeyingMaterial,
                bool(const std::string& label,
                     const uint8_t* context,
                     size_t context_len,
                     bool use_context,
                     uint8_t* result,
                     size_t result_len));
 };
 
 class TransportChannelSocketAdapterTest : public testing::Test {
@@ skipping 68 matching lines @@
 
   EXPECT_CALL(channel_, GetError())
       .WillOnce(Return(EWOULDBLOCK));
 
   int result = target_->Send(buffer.get(), kTestDataSize, callback_);
   ASSERT_EQ(net::OK, result);
 }
 
 }  // namespace protocol
 }  // namespace remoting