Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1847303004: S390: Fix '[ic] Use the CallFunction builtin to invoke accessors.' (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fix '[ic] Use the CallFunction builtin to invoke accessors.' Fix native compilation error due to gcc error "call of overloaded ‘Operand(int)’ is ambiguous" R=joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/9fbc04f8332f73f16be3b97d021ea4f42b7fc1da Cr-Commit-Position: refs/heads/master@{#35218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ic/s390/handler-compiler-s390.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-01 19:44:09 UTC) #1
JoranSiu
lgtm
4 years, 8 months ago (2016-04-01 22:08:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847303004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847303004/1
4 years, 8 months ago (2016-04-01 22:13:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 22:34:13 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 22:34:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fbc04f8332f73f16be3b97d021ea4f42b7fc1da
Cr-Commit-Position: refs/heads/master@{#35218}

Powered by Google App Engine
This is Rietveld 408576698