Add an API to report debugName in GraphicsLayer

Source/WebKit/chromium/src/PageOverlay.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  * 1. Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *
@@ skipping 63 matching lines @@
 
     virtual void notifyAnimationStarted(const GraphicsLayer*, double time) { }
 
     virtual void paintContents(const GraphicsLayer*, GraphicsContext& gc, GraphicsLayerPaintingPhase, const IntRect& inClip)
     {
         gc.save();
         m_overlay->paintPageOverlay(ToWebCanvas(&gc));
         gc.restore();
     }
 
+    virtual String debugName(const GraphicsLayer*) OVERRIDE
+    {
+        return String("WebViewImpl Page Overlay Content Layer");

[enne (OOO), 2013/07/30 17:31:05]

Can you ASSERT that layer here is m_layer?

[qiankun, 2013/07/31 11:16:28]

Done. 
1. There is no m_layer member in OverlayGraphicsLayerClientImpl. I added
"createGraphicsLayer()" to create and return m_layer in
OverlayGraphicsLayerClientImpl. 
2. The OverlayGraphicsLayerClientImpl class is moved to PageOverlay.h file. 
3. Changed "OwnPtr<WebCore::GraphicsLayerClient> m_layerClient;" to 
"OwnPtr<OverlayGraphicsLayerClientImpl> m_layerClient;". This is for calling
createGraphicsLayer() which is not a member function of
"WebCore::GraphicsLayerClient".

+    }
+
 private:
     explicit OverlayGraphicsLayerClientImpl(WebPageOverlay* overlay)
         : m_overlay(overlay)
     {
     }
 
     WebPageOverlay* m_overlay;
 };
 
 void PageOverlay::clear()
 {
     invalidateWebFrame();
 
     if (m_layer) {
         m_layer->removeFromParent();
         m_layer = nullptr;
         m_layerClient = nullptr;
     }
 }
 
 void PageOverlay::update()
 {
     invalidateWebFrame();
 
     if (!m_layer) {
         m_layerClient = OverlayGraphicsLayerClientImpl::create(m_overlay);
         m_layer = GraphicsLayer::create(m_viewImpl->graphicsLayerFactory(), m_layerClient.get());
-        m_layer->setName("WebViewImpl page overlay content");
         m_layer->setDrawsContent(true);
     }
 
     FloatSize size(m_viewImpl->size());
     if (size != m_layer->size()) {
         // Triggers re-adding to root layer to ensure that we are on top of
         // scrollbars.
         m_layer->removeFromParent();
         m_layer->setSize(size);
     }
@@ skipping 24 matching lines @@
         // this is not on a critical codepath? In order to do so, we'd
         // have to take scrolling into account.
         const WebSize& size = m_viewImpl->size();
         WebRect damagedRect(0, 0, size.width, size.height);
         if (m_viewImpl->client())
             m_viewImpl->client()->didInvalidateRect(damagedRect);
     }
 }
 
 } // namespace WebKit