MD History: Update Search Icon Margins

MD History: Update Search Icon Margins

Placement of search icon is too far to right.

Add 20px padding right to search-input.

BUG=598453
Committed: https://crrev.com/6c8e62802482f8bda9f7b910d4384f6df99b2aa7
Cr-Commit-Position: refs/heads/master@{#385122}

[lshang, 2016-03-31 23:55:44]

Description was changed from

==========
MD History: Update Search Icon Margins

BUG=598453
==========

to

==========
MD History: Update Search Icon Margins

Placement of search icon is too far to right.

Add a div around search icon which has 10px padding right, the same with 
downloads.

BUG=598453
==========

[lshang, 2016-03-31 23:57:08]

lshang@chromium.org changed reviewers:
+ calamity@chromium.org, tsergeant@chromium.org

[lshang, 2016-03-31 23:57:09]

PTAL thanks!

[tsergeant, 2016-04-04 00:10:34]

https://codereview.chromium.org/1847273002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/1847273002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:42: box-sizing:
border-box;
I don't think that box-sizing, display:flex or justify-content will actually do
anything here, so you can try getting rid of them.

You might find it simpler to set webkit-padding-end on the #search-input
directly, as well.

[lshang, 2016-04-05 00:21:53]

Tim, could you take a look again? thanks!

https://codereview.chromium.org/1847273002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/1847273002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:42: box-sizing:
border-box;
On 2016/04/04 00:10:34, tsergeant wrote:
> I don't think that box-sizing, display:flex or justify-content will actually
do
> anything here, so you can try getting rid of them.
> 
> You might find it simpler to set webkit-padding-end on the #search-input
> directly, as well.

Done.

[tsergeant, 2016-04-05 00:36:21]

lgtm!

[lshang, 2016-04-05 07:33:49]

Description was changed from

==========
MD History: Update Search Icon Margins

Placement of search icon is too far to right.

Add a div around search icon which has 10px padding right, the same with 
downloads.

BUG=598453
==========

to

==========
MD History: Update Search Icon Margins

Placement of search icon is too far to right.

Add 20px padding right to search-input.

BUG=598453
==========

[lshang, 2016-04-05 07:34:07]

The CQ bit was checked by lshang@chromium.org

[commit-bot: I haz the power, 2016-04-05 07:34:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847273002/20001

[commit-bot: I haz the power, 2016-04-05 07:39:41]

Description was changed from

==========
MD History: Update Search Icon Margins

Placement of search icon is too far to right.

Add 20px padding right to search-input.

BUG=598453
==========

to

==========
MD History: Update Search Icon Margins

Placement of search icon is too far to right.

Add 20px padding right to search-input.

BUG=598453
==========

[commit-bot: I haz the power, 2016-04-05 07:39:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-05 07:41:06]

Description was changed from

==========
MD History: Update Search Icon Margins

Placement of search icon is too far to right.

Add 20px padding right to search-input.

BUG=598453
==========

to

==========
MD History: Update Search Icon Margins

Placement of search icon is too far to right.

Add 20px padding right to search-input.

BUG=598453

Committed: https://crrev.com/6c8e62802482f8bda9f7b910d4384f6df99b2aa7
Cr-Commit-Position: refs/heads/master@{#385122}
==========

[commit-bot: I haz the power, 2016-04-05 07:41:07]

Patchset 2 (id:??) landed as
https://crrev.com/6c8e62802482f8bda9f7b910d4384f6df99b2aa7
Cr-Commit-Position: refs/heads/master@{#385122}