Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1847273002: MD History: Update Search Icon Margins (Closed)

Created:
4 years, 8 months ago by lshang
Modified:
4 years, 8 months ago
Reviewers:
tsergeant, calamity
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Update Search Icon Margins Placement of search icon is too far to right. Add 20px padding right to search-input. BUG=598453 Committed: https://crrev.com/6c8e62802482f8bda9f7b910d4384f6df99b2aa7 Cr-Commit-Position: refs/heads/master@{#385122}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressing review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/md_history/history_toolbar.html View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
lshang
PTAL thanks!
4 years, 8 months ago (2016-03-31 23:57:09 UTC) #3
tsergeant
https://codereview.chromium.org/1847273002/diff/1/chrome/browser/resources/md_history/history_toolbar.html File chrome/browser/resources/md_history/history_toolbar.html (right): https://codereview.chromium.org/1847273002/diff/1/chrome/browser/resources/md_history/history_toolbar.html#newcode42 chrome/browser/resources/md_history/history_toolbar.html:42: box-sizing: border-box; I don't think that box-sizing, display:flex or ...
4 years, 8 months ago (2016-04-04 00:10:34 UTC) #4
lshang
Tim, could you take a look again? thanks! https://codereview.chromium.org/1847273002/diff/1/chrome/browser/resources/md_history/history_toolbar.html File chrome/browser/resources/md_history/history_toolbar.html (right): https://codereview.chromium.org/1847273002/diff/1/chrome/browser/resources/md_history/history_toolbar.html#newcode42 chrome/browser/resources/md_history/history_toolbar.html:42: box-sizing: ...
4 years, 8 months ago (2016-04-05 00:21:53 UTC) #5
tsergeant
lgtm!
4 years, 8 months ago (2016-04-05 00:36:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847273002/20001
4 years, 8 months ago (2016-04-05 07:34:13 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 07:39:42 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 07:41:07 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6c8e62802482f8bda9f7b910d4384f6df99b2aa7
Cr-Commit-Position: refs/heads/master@{#385122}

Powered by Google App Engine
This is Rietveld 408576698